Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate and add TASK_ERROR support #609

Merged
merged 2 commits into from
Aug 12, 2015
Merged

Conversation

tpetr
Copy link
Contributor

@tpetr tpetr commented Jul 10, 2015

#598 + TASK_ERROR support

From http://mesos.apache.org/blog/mesos-0-21-0-released/:

We have also introduced the notion of a TASK_ERROR state, distinct from TASK_LOST. The semantic difference is that tasks that are updated as lost can be rescheduled and should succeed, while tasks with status error will continue to fail if they are rescheduled. In Mesos 0.21.0 we do not send TASK_ERROR but it has been defined so frameworks can prepare to receive it. We will start sending it in Mesos 0.22.0.

Steven Schlansker and others added 2 commits July 8, 2015 09:54
…State has a map entry

Improve error message should this somehow fail (right now it is "IllegalArgumentException: null"

Note that this causes tests to fail as we are missing the 'TASK_ERROR' state.
@tpetr tpetr added this to the 0.4.3 milestone Jul 10, 2015
@stevenschlansker
Copy link
Contributor

👍

@wsorenson
Copy link
Contributor

Are we going to add another PR for actually handling this state successfully? How should Singularity interpret TASK_ERROR?

@tpetr
Copy link
Contributor Author

tpetr commented Jul 24, 2015

Right now we treat TASK_ERROR as a terminal failure state, same as TASK_LOST. I imagine if the task is related to a deploy, we should immediately fail it. Not 100% sure what to do for the other situations (bounce, scale, etc.)

@tpetr tpetr force-pushed the validate-and-add-error-state branch from aa2f7f8 to 6785c4e Compare August 12, 2015 17:55
@tpetr
Copy link
Contributor Author

tpetr commented Aug 12, 2015

Better TASK_ERROR handling will be addressed in another PR -- filed #645 to track it for now.

@tpetr tpetr merged commit 6785c4e into master Aug 12, 2015
@tpetr tpetr removed hs_qa labels Aug 12, 2015
@ssalinas ssalinas deleted the validate-and-add-error-state branch August 17, 2015 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants