Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore old constructor in singularity request parent #2247

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Restore old constructor in singularity request parent #2247

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30b72e7
restore old constructor in singularity request parent
Dec 6, 2021
7501377
remove unneeded jsonproperty annotatons
Dec 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions SingularityBase/src/main/java/com/hubspot/singularity/SingularityRequestParent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,42 @@ public SingularityRequestParent(
);
}

@Deprecated
public SingularityRequestParent(
@JsonProperty("request") SingularityRequest request,
@JsonProperty("state") RequestState state,
@JsonProperty(
"requestDeployState"
) Optional<SingularityRequestDeployState> requestDeployState,
@JsonProperty("activeDeploy") Optional<SingularityDeploy> activeDeploy,
@JsonProperty("pendingDeploy") Optional<SingularityDeploy> pendingDeploy,
@JsonProperty(
"pendingDeployState"
) Optional<SingularityPendingDeploy> pendingDeployState,
@JsonProperty("expiringBounce") Optional<SingularityExpiringBounce> expiringBounce,
@JsonProperty("expiringPause") Optional<SingularityExpiringPause> expiringPause,
@JsonProperty("expiringScale") Optional<SingularityExpiringScale> expiringScale,
@JsonProperty(
"expiringSkipHealthchecks"
) Optional<SingularityExpiringSkipHealthchecks> expiringSkipHealthchecks,
@JsonProperty("taskIds") Optional<SingularityTaskIdsByStatus> taskIds
) {
this(
request,
state,
requestDeployState,
activeDeploy,
pendingDeploy,
pendingDeployState,
expiringBounce,
expiringPause,
expiringScale,
Optional.empty(),
expiringSkipHealthchecks,
taskIds
);
}

@JsonCreator
public SingularityRequestParent(
@JsonProperty("request") SingularityRequest request,
Expand Down