Add fire alarm #2241
Merged
Add fire alarm #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backend part looks fine. As for UI, I'm wondering if we should include this data in some version of the state json (or some other thing the UI already fetches on every page). Just trying to be careful about adding yet another api call made on every UI page |
|
Added to state. Should just get picked up without any kind of migration since it's an optional. |
rosalind210
reviewed
Nov 17, 2021
|
|
||
| @GET | ||
| @Path("/firealarm") | ||
| @Operation(summary = "Set a firealarm warning in singularity") |
There was a problem hiding this comment.
nit: this is the same summary as the post endpoint
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly basic fire alarm capability for Singularity.
The idea is that in an emergency, when users taking certain actions could be destructive (e.g. bouncing while agent capacity is low due to an outage) but we don't want to outright disallow then, a banner can be displayed warning users about the potential consequences of certain actions.
This allows setting, updating, and deleting a firealarm. Can easily make it more sophisticated if necessary.
This does not include UI updates. When it's time to implement that, the banner should probably also check the disasters resource to check what actions are currently explicitly disallowed.