Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less Terminal #2070

Merged
merged 61 commits into from
Apr 24, 2020
Merged

Less Terminal #2070

merged 61 commits into from
Apr 24, 2020

Conversation

WH77
Copy link
Contributor

@WH77 WH77 commented Feb 7, 2020

Adds experimental support for a shell-like less terminal in the task file browser, behind a new configuration flag.

cc - @ssalinas, @baconmania

@WH77 WH77 added the WIP label Feb 7, 2020
SingularityUI/package.json Outdated Show resolved Hide resolved
@ssalinas
Copy link
Member

One overall thing we need to discuss in this case is that we hadn't initially planned on open sourcing the shel socket backend, so we need to determine if this UI component is best suited here or somewhere else. Can chat offline about that as well

@WH77 WH77 force-pushed the experimental/shell-log branch from e1a88d2 to 9ca8bb2 Compare February 21, 2020 17:52
@ssalinas ssalinas added this to the 1.3.0 milestone Feb 26, 2020
@WH77 WH77 added the hs_qa label Mar 9, 2020
@WH77 WH77 removed the WIP label Apr 24, 2020
@WH77 WH77 changed the title [WIP] Less Terminal Less Terminal Apr 24, 2020
@WH77 WH77 merged commit 3468455 into master Apr 24, 2020
@WH77 WH77 deleted the experimental/shell-log branch April 24, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants