Prioritize memory shuffles over cpu #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baconmania
reviewed
Dec 11, 2019
Comment on lines
+162
to
+168
| if (mostOverusedResource1.resourceType != mostOverusedResource2.resourceType) { | ||
| if (mostOverusedResource1.resourceType == Type.MEMORY) { | ||
| return -1; | ||
| } else { | ||
| return 1; | ||
| } | ||
| } |
There was a problem hiding this comment.
Hmm, this short circuits all resource comparisons when the two resources being compared aren't the same. So like, if we're comparing DISK vs CPU, whichever one is mostOverusedResource1 would always sort as higher. Is that the intent? Should we scope this logic to the specific scenario when one of the resources being compared is MEMORY?
There was a problem hiding this comment.
We don't have shuffles for disk so far. Type can only be MEM or CPU
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory ones are generally more urgent, take care of them first