Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return early for missing deploy #2021

Merged
merged 1 commit into from
Oct 4, 2019
Merged

return early for missing deploy #2021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...rityService/src/main/java/com/hubspot/singularity/scheduler/SingularityDeployChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,7 @@ private boolean isDeployOverdue(SingularityPendingDeploy pendingDeploy, Optional
if (!deploy.isPresent()) {
if (System.currentTimeMillis() - pendingDeploy.getDeployMarker().getTimestamp() > TimeUnit.SECONDS.toMillis(configuration.getDeployHealthyBySeconds())) {
LOG.warn("Can't determine if deploy {} is overdue because it was missing, but pending time is > {}s, marking as overdue", pendingDeploy, configuration.getDeployHealthyBySeconds());
return true;
} else {
LOG.warn("Can't determine if deploy {} is overdue because it was missing", pendingDeploy);
return false;
Expand Down