Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to mesos 1.6.1 and fork of mesos-rxjava #1867

Merged
merged 9 commits into from
Nov 6, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SingularityExecutor/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM mesosphere/mesos:1.1.1
FROM mesosphere/mesos-slave:1.6.1-rc2
## mesos + java used to build hubspot/singularitybase

MAINTAINER platform-infrastructure-groups@hubspot.com
Expand Down
6 changes: 5 additions & 1 deletion SingularityExecutor/src/main/resources/runner.sh.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@
# Task ID: {{{ taskId }}}
#

export MESOS_TASK_ID={{{bashEscaped taskId}}} # I can't believe Mesos doesn't expose this.
export MESOS_TASK_ID=$TASK_ID

# MESOS-8322 changed this directory to 0750, chown owner since we can switch user either in mesos or the executor.
# Otherwise, when switching user in the executor only, the non-root user can no longer traverse the sandbox
chown {{{ user }}} $MESOS_SANDBOX

{{#if cfsQuota }}
# Outputs the path of the deepest cgroup the current process is in.
Expand Down
1 change: 0 additions & 1 deletion SingularityS3Uploader/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@

<properties>
<basepom.shaded.main-class>com.hubspot.singularity.s3uploader.SingularityS3UploaderRunner</basepom.shaded.main-class>
<dep.protobuf.version>3.5.1</dep.protobuf.version>
</properties>

<dependencies>
Expand Down
6 changes: 3 additions & 3 deletions SingularityService/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -128,17 +128,17 @@
</dependency>

<dependency>
<groupId>com.mesosphere.mesos.rx.java</groupId>
<groupId>com.hubspot.mesos.rx.java</groupId>
<artifactId>mesos-rxjava-client</artifactId>
</dependency>

<dependency>
<groupId>com.mesosphere.mesos.rx.java</groupId>
<groupId>com.hubspot.mesos.rx.java</groupId>
<artifactId>mesos-rxjava-protobuf-client</artifactId>
</dependency>

<dependency>
<groupId>com.mesosphere.mesos.rx.java</groupId>
<groupId>com.hubspot.mesos.rx.java</groupId>
<artifactId>mesos-rxjava-util</artifactId>
</dependency>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ protected void configure() {
bind(UserManager.class).in(Scopes.SINGLETON);
bind(UsageManager.class).in(Scopes.SINGLETON);

bind(NotificationsManager.class).in(Scopes.SINGLETON);

bind(SingularityWebCache.class).in(Scopes.SINGLETON);

bind(ExecutorIdGenerator.class).in(Scopes.SINGLETON);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@
import com.hubspot.singularity.config.SingularityConfiguration;
import com.hubspot.singularity.config.UIConfiguration;
import com.hubspot.singularity.resources.ui.UiResource;
import com.mesosphere.mesos.rx.java.AwaitableSubscription;
import com.mesosphere.mesos.rx.java.MesosClient;
import com.mesosphere.mesos.rx.java.MesosClientBuilder;
import com.mesosphere.mesos.rx.java.SinkOperation;
import com.mesosphere.mesos.rx.java.SinkOperations;
import com.mesosphere.mesos.rx.java.protobuf.ProtobufMesosClientBuilder;
import com.mesosphere.mesos.rx.java.util.UserAgentEntries;
import com.hubspot.mesos.rx.java.AwaitableSubscription;
import com.hubspot.mesos.rx.java.MesosClient;
import com.hubspot.mesos.rx.java.MesosClientBuilder;
import com.hubspot.mesos.rx.java.SinkOperation;
import com.hubspot.mesos.rx.java.SinkOperations;
import com.hubspot.mesos.rx.java.protobuf.ProtobufMesosClientBuilder;
import com.hubspot.mesos.rx.java.util.UserAgentEntries;

import rx.BackpressureOverflow;
import rx.Observable;
Expand Down Expand Up @@ -152,6 +152,7 @@ private void connect(URI mesosMasterURI, FrameworkInfo frameworkInfo, Singularit
MesosClientBuilder<Call, Event> clientBuilder = ProtobufMesosClientBuilder.schedulerUsingProtos()
.mesosUri(mesosMasterURI)
.applicationUserAgentEntry(UserAgentEntries.userAgentEntryForMavenArtifact("com.hubspot.singularity", "SingularityService"))
.onSendEventBackpressureBuffer()
.onBackpressureBuffer(
scheduler.getEventBufferSize(),
() -> {
Expand Down
3 changes: 2 additions & 1 deletion compose-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ zk:
ZK_ID: 1

master:
image: mesosphere/mesos-master:1.1.1
image: mesosphere/mesos-master:1.6.1-rc2
net: host
environment:
MESOS_ZK: zk://localhost:2181/mesos
Expand All @@ -31,6 +31,7 @@ slave:
MESOS_ATTRIBUTES: "example:value;myNumber:1"
MESOS_ISOLATION: cgroups/cpu,cgroups/mem
MESOS_WORK_DIR: /var/lib/mesos/agent
MESOS_SYSTEMD_ENABLE_SUPPORT: "false"
volumes:
- /var/run/docker.sock:/var/run/docker.sock
- /sys:/sys
Expand Down
23 changes: 12 additions & 11 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -61,21 +61,22 @@
<dep.jackson-databind.version>2.9.4</dep.jackson-databind.version>
<dep.jackson.version>2.9.4</dep.jackson.version>
<dep.javassist.version>3.21.0-GA</dep.javassist.version>
<dep.mesos.rxjava.version>0.2.0</dep.mesos.rxjava.version>
<dep.mesos.rxjava.version>0.1.0</dep.mesos.rxjava.version>
<dep.rxJava.version>1.3.8</dep.rxJava.version>
<dep.metrics-guice.version>3.1.3</dep.metrics-guice.version>
<dep.netty.version>4.1.22.Final</dep.netty.version>
<dep.protobuf.version>2.6.1</dep.protobuf.version>
<dep.protobuf-java.version>3.5.1</dep.protobuf-java.version>
<dep.reflections.version>0.9.11</dep.reflections.version>
<dep.swagger.version>2.0.0</dep.swagger.version>

<dropwizard.guicier.version>1.0.6.0</dropwizard.guicier.version>
<horizon.version>0.0.25</horizon.version>
<jukito.version>1.5</jukito.version>
<mesos.docker.tag>1.1.1</mesos.docker.tag>
<mesos.version>1.1.2</mesos.version>
<mesos.docker.tag>1.6.1</mesos.docker.tag>
<mesos.version>1.6.1</mesos.version>
<project.build.targetJdk>1.8</project.build.targetJdk>
<singularity.jar.name.format>${project.artifactId}-${project.version}</singularity.jar.name.format>
<singularitybase.image.revision>1</singularitybase.image.revision>
<singularitybase.image.revision>2</singularitybase.image.revision>
</properties>

<dependencyManagement>
Expand Down Expand Up @@ -149,7 +150,7 @@
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
<version>${dep.protobuf.version}</version>
<version>${dep.protobuf-java.version}</version>
</dependency>

<dependency>
Expand Down Expand Up @@ -244,7 +245,7 @@
<dependency>
<groupId>com.hubspot.jackson</groupId>
<artifactId>jackson-datatype-protobuf</artifactId>
<version>0.9.9-jackson2.9-proto2</version>
<version>0.9.10-jackson2.9-proto3</version>
</dependency>

<dependency>
Expand All @@ -254,19 +255,19 @@
</dependency>

<dependency>
<groupId>com.mesosphere.mesos.rx.java</groupId>
<groupId>com.hubspot.mesos.rx.java</groupId>
<artifactId>mesos-rxjava-client</artifactId>
<version>${dep.mesos.rxjava.version}</version>
</dependency>

<dependency>
<groupId>com.mesosphere.mesos.rx.java</groupId>
<groupId>com.hubspot.mesos.rx.java</groupId>
<artifactId>mesos-rxjava-protobuf-client</artifactId>
<version>${dep.mesos.rxjava.version}</version>
</dependency>

<dependency>
<groupId>com.mesosphere.mesos.rx.java</groupId>
<groupId>com.hubspot.mesos.rx.java</groupId>
<artifactId>mesos-rxjava-util</artifactId>
<version>${dep.mesos.rxjava.version}</version>
</dependency>
Expand Down Expand Up @@ -308,7 +309,7 @@
<dependency>
<groupId>io.reactivex</groupId>
<artifactId>rxjava</artifactId>
<version>1.1.8</version>
<version>${dep.rxJava.version}</version>
</dependency>

<dependency>
Expand Down