Highlight new files #1610
Merged
Highlight new files #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyhuang91
reviewed
Aug 15, 2017
| @@ -40,6 +42,10 @@ function sortData(cellData, file) { | |||
| return file; | |||
| } | |||
|
|
|||
| function isRecentlyModified(mtime) { | |||
| return new Date().getTime() / 1000 - mtime <= RECENTLY_MODIFIED_SECONDS; | |||
There was a problem hiding this comment.
Date.now() is equivalent to new Date().getTime()
| @@ -64,18 +70,33 @@ function TaskFileBrowser (props) { | |||
| return _.sortBy(props.files, 'isDirectory').reverse(); | |||
| } | |||
|
|
|||
| function recentlyModifiedTooltip() { | |||
There was a problem hiding this comment.
This doesn't have to be a function. You can create it once and assign it to a variable.
const recentlyModifiedTooltip = <Tooltip />;
<OverlayTrigger overlay={recentlyModifiedTooltip} />
| return ( | ||
| <div> | ||
| <Breadcrumbs items={pathItems} /> | ||
| <UITable | ||
| data={getFiles() || []} | ||
| keyGetter={(file) => file.name} | ||
| rowClassName={({mtime}) => { return isRecentlyModified(mtime) ? 'bg-info-light' : null; }} |
There was a problem hiding this comment.
This will only update if something else causes this component to re-render. Is this the behavior that you want?
There was a problem hiding this comment.
The app globally refreshes this data every 60 seconds, and when the window regains focus, so this shouldn't get out of sync.
| label="" | ||
| id="icon" | ||
| key="icon" | ||
| cellData={(file) => isRecentlyModified(file.mtime) && |
There was a problem hiding this comment.
Because this depends on the current time, you should evaluate this once at the beginning of the render function instead of calling it 3 times.
tpetr
approved these changes
Sep 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users want a way to determine if a file is currently being written to, especially in cases where downloading an incomplete file such as a heap dump would be undesirable.
The task file browser will highlight files that have been modified in the last 60 seconds.