Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Mesos 1) Better backpressure and abort logic #1601

Merged
merged 4 commits into from
Jul 25, 2017
Merged

Conversation

ssalinas
Copy link
Member

Two things in this PR:

  • We weren't setting up the appropriate backpressure for the mesos master events observable. Now we will buffer up to the configured number of events. If the buffer overflows we will bail. By default this is set to 5000, which should be plenty to handle the surges of events from most reconciliation calls
  • Smoother aborts without the need for SingletonCloser class. While it closed everything, we were closing the zk connection before the server was appropriately shut down, causing 'instance not started' exceptions for a few requests. With previous changes in place, closing the leader latch will allow the scheduler to shut down gracefully, so I am only explicitly running that step before shutting down the server

PRed to mesos_1 branch, will merge once this is also in hs_qa

@ssalinas ssalinas added the hs_qa label Jul 25, 2017
@ssalinas
Copy link
Member Author

changes are in hs_qa, merging this into the mesos_1 branch

@ssalinas ssalinas merged commit eb805ae into mesos_1 Jul 25, 2017
@ssalinas ssalinas deleted the backpressure branch July 25, 2017 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant