jets3t -> aws sdk #1394
Merged
jets3t -> aws sdk #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpetr
reviewed
Jan 9, 2017
| @@ -131,7 +131,7 @@ public void setLocalDownloadPath(String localDownloadPath) { | |||
| this.localDownloadPath = localDownloadPath; | |||
| } | |||
|
|
|||
| public long getS3ChunkDownloadTimeoutMillis() { | |||
| public Long getS3ChunkDownloadTimeoutMillis() { | |||
There was a problem hiding this comment.
in order to more cleanly call intValue() (aws sdk takes an int). Was debating if it was cleaner to keep the TimeUnit.SECONDS.toMillis(30)so the default is readable and have to do long -> int, or to move it all to int. Reading it now the second probably makes more sense, I'll update
There was a problem hiding this comment.
I'd say let's change this to int. The max value of a Java integer in milliseconds is a little more than 24 days, which should be more then enough for this timeout.
|
LGTM |
|
This is working fine in staging, going to merge it with the other s3-related PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving us to the aws sdk. This is partly just to keep up to date, but also so that we can use the new
GetObjectV2to do pagination when listing buckets in the future.aws.sdk.versionis bumped to1.10.77for now.1.10.xis the first to have the new v2 request (basepom has1.9.x). Going all the way to1.11.xcreated too many dependency issues.PRing this into the other S3 rework branch.
/cc @tpetr