Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add case-sensitive paths plugin #1202

Merged
merged 1 commit into from
Aug 10, 2016
Merged

Add case-sensitive paths plugin #1202

merged 1 commit into from
Aug 10, 2016

Conversation

Calvinp
Copy link
Contributor

@Calvinp Calvinp commented Aug 10, 2016

This adds the case-sensitive paths plugin Singularity UI - thus preventing the issue where builds succeed locally but not in Jenkins because the OSX filesystem is case-insensitive.
Now it'll fail locally with this error:

ERROR in ./app/components/tasks/TasksPage.jsx
Module not found: Error: [CaseSensitivePathsPlugin] `/Users/cpomerantz/repos/Singularity/SingularityUI/app/rootcomponent.jsx` does not match the corresponding path on disk `rootComponent.jsx`.
 @ ./app/components/tasks/TasksPage.jsx 17:21-51

cc @tpetr @wolfd @kwm4385

@tpetr
Copy link
Contributor

tpetr commented Aug 10, 2016

LGTM

@Calvinp Calvinp merged commit 9a5d2aa into decaf Aug 10, 2016
@Calvinp Calvinp deleted the case_sensitive_paths_plugin branch August 10, 2016 14:56
@Calvinp Calvinp mentioned this pull request Aug 10, 2016
Closed
@tpetr tpetr modified the milestone: 0.10.0 Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Calvinp @tpetr