Merge pull request #1535 from HubSpot/verify_path

Ensure path is set on read endpoint
HubSpot · May 22, 2017 · 6d29d45 · 6d29d45
2 parents b3627ec + 56fcfe2
commit 6d29d45
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/SingularityService/src/main/java/com/hubspot/singularity/resources/SandboxResource.java b/SingularityService/src/main/java/com/hubspot/singularity/resources/SandboxResource.java
@@ -1,6 +1,7 @@
 package com.hubspot.singularity.resources;
 
 import static com.hubspot.singularity.WebExceptions.badRequest;
+import static com.hubspot.singularity.WebExceptions.checkBadRequest;
 import static com.hubspot.singularity.WebExceptions.checkNotFound;
 import static com.hubspot.singularity.WebExceptions.notFound;
 
@@ -137,6 +138,8 @@ public MesosFileChunkObject read(@ApiParam("The task ID of the sandbox to read f
 
     final SingularityTaskHistory history = checkHistory(taskId);
 
+    checkBadRequest(!Strings.isNullOrEmpty(path), "Must specify 'path'");
+
     final String slaveHostname = history.getTask().getOffer().getHostname();
     final String fullPath = new File(history.getDirectory().get(), path).toString();