Update groups, countries, Eurovoc terms #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillprochaska
force-pushed
the
static-data
branch
3 times, most recently
from
9732af7 to
185220e
Compare
tillprochaska
commented
Feb 3, 2025
There was a problem hiding this comment.
The issue you were seeing should now be fixed. We should probably reaggregate votes after deployment using htv aggregate votes to make sure these changes are also reflected in the search index.
tillprochaska
force-pushed
the
static-data
branch
from
c65f75c to
31dfc6c
Compare
These values are sets, i.e. order isn’t stable which means there will often be large diffs even in case of small or no changes.
Some of the SPARQL endpoints we use now block GET requests that pass the SPARQL query as a URL query parameter. POST requests work fine for all endpoints.
We previously used the DC Terms `identifier` property. However, this property is sometimes ambiguous. For example, the domain concept "AGRICULTURE, FORESTRY AND FISHERIES" has the DC Terms identifier `56`, but the correct ID is `100156`. Instead, we now extract the ID from the resource URI (`http://eurovoc.europa.eu/100156` in this example).
linusha
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the last remaining task in #960.
I’ve also implemented a few small changes to sort records and list values. This should make it much easier to diff the resulting JSON files. (Right now, rerunning some of the
htv load-*commands can lead to large diffs, even though there have been only small or no changes.)Also had to fix how we send SPARQL requests because some SPARQL endpoints now only accept POST requests. (We were using GET requests before.)