Add warning for PRINTCOUNTER_SAVE_INTERVAL on ESP32 I2S expander #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add warning if PRINTCOUNTER_SAVE_INTERVAL is enabled (>0) on an ESP32 board with an I2S expander.
Erasing flash (emulating EEPROM) on an ESP32 takes quite a long time and, if carried out during printing can result in missed steps and layer shifts. Not absolutely certain but I think the I2S expander DMA buffers are underflowing as all code execution stops during a flash erase (buffers are swapped/filled by an interrupt and a separate task both of which will stall during the flash erase).
If flash updates are carried out when not printing the same stalling occurs BUT even if the continuously running I2S was to undeflow the hardware just re-sends the last word in the buffer when empty (and, 32mSec max. after a print has stopped) that will be the inactive state for any stepper drives).
Requirements
Any ESP32 board with an I2S expander.
Benefits
Prevents missed steps/ layer shifts
Related Issues
MarlinFirmware#24753
MarlinFirmware#24731