Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NSM mention in desktop file #1

Closed
wants to merge 1 commit into from

Conversation

Houston4444
Copy link
Owner

Hi @theGreatWhiteShark .

add NSM mention to the desktop file allows it to be listed by NSM session managers. See jackaudio/new-session-manager#40 .

Now in RaySession, it prevents to need to check version with hydrogen --version.

I don't know if it is possible to build hydrogen without liblo, if it is the case, this key 'X-NSM-Capable' should be set on true or false conditionally.

@theGreatWhiteShark
Copy link

Hey @Houston4444 ,

You set the master branch of your fork as target of this PR. Is this intended?

Sounds good to me. But I have to admit that I don't know much about XDG. Hydrogen itself is not XDG-compatible yet (see hydrogen-music#643). I'm not quite sure whether this might affect the changes you applied.

@Houston4444
Copy link
Owner Author

You set the master branch of your fork as target of this PR. Is this intended?

Oh, its a mistake (directly made in github), but not strong, I removed my fork and re-fork before the PR.

Hydrogen itself is not XDG-compatible yet

This key is XDG-compatible, If I have the key in the desktop file, it is ok for me, I don't care about the rest of XDG. The .desktop file is already installed at the good place ;).

@theGreatWhiteShark
Copy link

The .desktop file is already installed at the good place

Great.

Could you make a PR containing these changes against the master branch of hydrogen?

@Houston4444
Copy link
Owner Author

Heeee ! I haven't seen I was making a PR on my own fork !!! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants