Skip to content
This repository has been archived by the owner on Jun 15, 2021. It is now read-only.

Commit

Permalink
Merge pull request #4 from HotelsDotCom/merge-upstream
Browse files Browse the repository at this point in the history
Merge upstream
  • Loading branch information
Kyle Hodgetts authored Mar 27, 2018
2 parents 644a532 + ab84973 commit 63de6c5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions docs/getting-started/step-4-update.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ More concretely, steps should be taken in order to rotate your certs on nodes ar
kube-aws update
```

There are cases where the service account tokens used by the system pods become invalid after credentials update, and
some of your system pods will break (especially `kube-dns`). Deleting the said secrets will solve the issue (see https://github.com/kubernetes-incubator/kube-aws/issues/1057).

## The etcd caveat

There is no solution for hosting an etcd cluster in a way that is easily updateable in this fashion- so updates are automatically masked for the etcd instances. This means that, after the cluster is created, nothing about the etcd ec2 instances is allowed to be updated.
Expand Down
2 changes: 1 addition & 1 deletion make/test
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ default() {
with-cover() {
test -z "$(find . -path ./vendor -prune -type f -o -name '*.go' -exec gofmt -d {} + | tee /dev/stderr)"
for d in $(go list ./... | grep -v '/vendor/' | grep -v '/hack'); do
go test -timeout 25m -v --race -coverprofile=profile.out -covermode=atomic $d
go test -timeout 30m -v --race -coverprofile=profile.out -covermode=atomic $d
if [ -f profile.out ]; then
cat profile.out >> coverage.txt
rm profile.out
Expand Down

0 comments on commit 63de6c5

Please sign in to comment.