Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

need forgot password link #6

Closed
4 tasks
jglovier opened this issue Jul 13, 2014 · 31 comments
Closed
4 tasks

need forgot password link #6

jglovier opened this issue Jul 13, 2014 · 31 comments
Labels
🚀enhancement an issue/pull request that adds a feature to the application v2.x

Comments

@jglovier
Copy link
Member

jglovier commented Jul 13, 2014

Right now if you forget your password, you are SOL. We should add a password recovery feature for users. Ideally, this would be part of the front end for users to trigger, but also something that admins could also trigger for users.

TODO

  • Create a new route
    • ask for username (form)
    • send email with link to ask for login to the system (API call to send email)
    • changes password (update database with new password (in couch)
@tangollama tangollama added the help wanted indicates that an issue is open for contributions label Sep 25, 2015
@tangollama tangollama modified the milestone: HospitalRun 1.0 Oct 12, 2015
@richchurcher
Copy link
Contributor

@tangollama I can take a look at this one.

@tangollama
Copy link
Member

Awesome. Blossom. Please do. I'll take it off the help wanted list tomorrow.

Typed or dictated imperfectly on my iPhone (717.385.9970)

On Dec 5, 2015, at 6:45 PM, Rich Churcher notifications@github.com wrote:

@tangollama I can take a look at this one.


Reply to this email directly or view it on GitHub.

@tangollama tangollama removed the help wanted indicates that an issue is open for contributions label Dec 7, 2015
@tangollama
Copy link
Member

Removed Help Wanted as @richchurcher is looking into it.

@jglovier
Copy link
Member Author

Bump. @richchurcher did you have a chance to look into this yet? Any update? When you get a PR open, feel free to cc me on it and I'll work with you on the styling.

@tangollama
Copy link
Member

@richchurcher, I'm going to put this back in the Help Wanted pool for now. If you ping back, I'll mark as In Progress.

@tangollama tangollama added the help wanted indicates that an issue is open for contributions label Mar 15, 2016
@richchurcher
Copy link
Contributor

@tangollama I sincerely apologise for this lapse! I became crazy busy with work, and this fell off my radar entirely. I now no longer have the bandwidth to contribute as I had hoped, but best wishes for the project in the future!

@dutad
Copy link

dutad commented Apr 8, 2016

I haven't even set up my dev environment for this project yet but I can look into this in the next few days. May take more than the allotted LOE because of being too busy...

@tangollama
Copy link
Member

That's sounds great. If you want to tackle it, I'll be sure to flag it as in progress.

Typed or dictated imperfectly on my iPhone (717.385.9970)

On Apr 8, 2016, at 4:15 PM, Daniel Dut A. notifications@github.com wrote:

I haven't even set up my dev environment for this project yet but I can look into this in the next few days. May take more than the allotted LOE because of being too busy...


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@tangollama tangollama added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels Apr 22, 2016
@tangollama
Copy link
Member

@DanielDut how's this coming?

@dutad
Copy link

dutad commented Apr 23, 2016

@tangollama, I have had difficulties running the project on my machine. I haven't started on it yet. I have a Windows-based PC and installing Cygwin was painfully unsuccessful. Trying it on a VM running Ubuntu is giving me build error on "Broccoli Plugin".

@tangollama
Copy link
Member

@DanielDut any progress here? Should I move this back to Help Wanted?

@dutad
Copy link

dutad commented May 15, 2016

@tangollama, I just got a new macbook air yesterday (just for this :) ) and setting up, let me get back to you in one week's time...

@tangollama
Copy link
Member

@DanielDut, have you had a chance to work on this?

@tangollama
Copy link
Member

@DanielDut any update here?

@captain-enjoyable
Copy link
Contributor

@emurillo510 and I started on this task, and set up the necessary route. We weren't sure how to move forward without an api endpoint.
image
image

@billybonks
Copy link
Contributor

@MattEddy i think adding a forgot password route here would work https://github.com/HospitalRun/hospitalrun-server-routes/blob/master/routes/30-auth.js.

perhaps post '/auth/forgot' would be an appropriate route

@jkleinsc do you recommend a differen't route and a mailer ?

@jkleinsc
Copy link
Member

jkleinsc commented Oct 5, 2016

@billybonks @MattEddy yes I think putting it in the auth route makes sense and /auth/forgot works. As far as a mailer, maybe https://www.npmjs.com/package/nodemailer for flexibility but I am open to other suggestions.

@EthanDavis
Copy link

Is anyone still working on this if not I would be interesting in helping out.

@broerse
Copy link

broerse commented Feb 14, 2017

@EthanDavis I am working on a serverless solution for this on our CouchDB projects. I also use nodemailer. See my first steps: https://github.com/martinic/openwhisk-mailer
If I have all parts working it is perhaps interesting for reference.

@jkleinsc
Copy link
Member

@EthanDavis it looks like effort on this has grown stale, so feel free to help out. This will require two pieces - the frontend as well as code added to https://github.com/HospitalRun/hospitalrun-server-routes/blob/master/routes/30-auth.js to handle the server side (eg email).

@EthanDavis
Copy link

@jkleinsc Okay thanks I will.

@EthanDavis
Copy link

@jkleinsc Should to forgot password link route to a new page or pull up a modal?
This might take me more than a week. I'm not super familiar with Ember. Just want to make sure.

Thanks!

@tangollama
Copy link
Member

@EthanDavis my apologies that I didn't reply sooner. Are you still interested in this issue? If not, I'll move it back to Help Wanted.

@stukalin
Copy link
Contributor

stukalin commented Apr 4, 2018

@jglovier @tangollama @jkleinsc I started working on this issue. Which email transport should we use? I've had an old sendgrid acc, will use it so far for testing purposes. Does HR have some SMTP already or can we setup sendgrid or smt similar?

@stukalin
Copy link
Contributor

stukalin commented Apr 4, 2018

Oh, wait, bullshit. There should be something more clever since we are not able to share a single api key among all our users... Some kind of SMTP transport configuration each user can configure on their own. Will think about that....

@jkleinsc
Copy link
Member

jkleinsc commented Apr 4, 2018

@stukalin yeah, I would make it configurable.

@jglovier
Copy link
Member Author

jglovier commented Apr 6, 2018

Is there a Node package for something like this? All we would really need to do is have the client ask the db for a reset pw link and send the user at that machine an email, right?

@stukalin
Copy link
Contributor

stukalin commented Apr 10, 2018

@jglovier I double-checked and I think we still go with nodemailer and its default SMTP transport. Even if someone wants to use Send Grid or Mandrill or whatever, these services provide SMTP settings (at least these 2 do). So we should cover the majority of setups.

stukalin added a commit that referenced this issue Aug 14, 2018
Update dependencies to enable Greenkeeper 🌴
MatthewDorner added a commit that referenced this issue Aug 18, 2018
@sarathsoma
Copy link

@jglovier Is this still pending ? I can take this up

@stukalin
Copy link
Contributor

it was pending, yes. I think I pushed my intermediate state into a branch with the corresponding name. Just look it up

@matteovivona matteovivona added v2.x in progress indicates that issue/pull request is currently being worked on and removed Hack Day in progress indicates that issue/pull request is currently being worked on labels Aug 6, 2019
@stale

This comment has been minimized.

@stale stale bot added the wontfix indicates an issue/pull request will not be worked on label Oct 5, 2019
@matteovivona matteovivona removed the wontfix indicates an issue/pull request will not be worked on label Oct 5, 2019
@fox1t fox1t closed this as completed Jan 14, 2020
matteovivona pushed a commit that referenced this issue Jan 15, 2021
fix #4 - expected console.error in tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚀enhancement an issue/pull request that adds a feature to the application v2.x
Projects
None yet
Development

No branches or pull requests