-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
need forgot password link #6
Comments
@tangollama I can take a look at this one. |
Awesome. Blossom. Please do. I'll take it off the help wanted list tomorrow. Typed or dictated imperfectly on my iPhone (717.385.9970)
|
Removed Help Wanted as @richchurcher is looking into it. |
Bump. @richchurcher did you have a chance to look into this yet? Any update? When you get a PR open, feel free to cc me on it and I'll work with you on the styling. |
@richchurcher, I'm going to put this back in the Help Wanted pool for now. If you ping back, I'll mark as In Progress. |
@tangollama I sincerely apologise for this lapse! I became crazy busy with work, and this fell off my radar entirely. I now no longer have the bandwidth to contribute as I had hoped, but best wishes for the project in the future! |
I haven't even set up my dev environment for this project yet but I can look into this in the next few days. May take more than the allotted LOE because of being too busy... |
That's sounds great. If you want to tackle it, I'll be sure to flag it as in progress. Typed or dictated imperfectly on my iPhone (717.385.9970)
|
@DanielDut how's this coming? |
@tangollama, I have had difficulties running the project on my machine. I haven't started on it yet. I have a Windows-based PC and installing Cygwin was painfully unsuccessful. Trying it on a VM running Ubuntu is giving me build error on "Broccoli Plugin". |
@DanielDut any progress here? Should I move this back to Help Wanted? |
@tangollama, I just got a new macbook air yesterday (just for this :) ) and setting up, let me get back to you in one week's time... |
@DanielDut, have you had a chance to work on this? |
@DanielDut any update here? |
@emurillo510 and I started on this task, and set up the necessary route. We weren't sure how to move forward without an api endpoint. |
@MattEddy i think adding a forgot password route here would work https://github.com/HospitalRun/hospitalrun-server-routes/blob/master/routes/30-auth.js. perhaps @jkleinsc do you recommend a differen't route and a mailer ? |
@billybonks @MattEddy yes I think putting it in the auth route makes sense and |
Is anyone still working on this if not I would be interesting in helping out. |
@EthanDavis I am working on a serverless solution for this on our CouchDB projects. I also use nodemailer. See my first steps: https://github.com/martinic/openwhisk-mailer |
@EthanDavis it looks like effort on this has grown stale, so feel free to help out. This will require two pieces - the frontend as well as code added to https://github.com/HospitalRun/hospitalrun-server-routes/blob/master/routes/30-auth.js to handle the server side (eg email). |
@jkleinsc Okay thanks I will. |
@jkleinsc Should to forgot password link route to a new page or pull up a modal? Thanks! |
@EthanDavis my apologies that I didn't reply sooner. Are you still interested in this issue? If not, I'll move it back to Help Wanted. |
@jglovier @tangollama @jkleinsc I started working on this issue. Which email transport should we use? I've had an old sendgrid acc, will use it so far for testing purposes. Does HR have some SMTP already or can we setup sendgrid or smt similar? |
Oh, wait, bullshit. There should be something more clever since we are not able to share a single api key among all our users... Some kind of SMTP transport configuration each user can configure on their own. Will think about that.... |
@stukalin yeah, I would make it configurable. |
Is there a Node package for something like this? All we would really need to do is have the client ask the db for a reset pw link and send the user at that machine an email, right? |
@jglovier I double-checked and I think we still go with |
Update dependencies to enable Greenkeeper 🌴
@jglovier Is this still pending ? I can take this up |
it was pending, yes. I think I pushed my intermediate state into a branch with the corresponding name. Just look it up |
This comment has been minimized.
This comment has been minimized.
fix #4 - expected console.error in tests
Right now if you forget your password, you are SOL. We should add a password recovery feature for users. Ideally, this would be part of the front end for users to trigger, but also something that admins could also trigger for users.
TODO
The text was updated successfully, but these errors were encountered: