Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Qt: Add support for Mountain Lion without excluding webkit #13640

Closed
wants to merge 2 commits into from
Closed

Qt: Add support for Mountain Lion without excluding webkit #13640

wants to merge 2 commits into from

Conversation

mattyr
Copy link

@mattyr mattyr commented Jul 27, 2012

Bit hack-y but gets the job done without an upstream fix. issue #13368

@shigeya
Copy link
Contributor

shigeya commented Jul 27, 2012

(duplicate note) I could build capybara-webkit and looks like working.

@mattyr
Copy link
Author

mattyr commented Jul 27, 2012

@shigeya Awesome.

I ran a few capybara-webkit test suites that also passed, so as far as webkit it should be working (if not the prettiest). I don't foresee this change causing failures in other areas of qt, but to be honest I'm focused on just qtwebkit at the moment...

@shigeya
Copy link
Contributor

shigeya commented Jul 27, 2012

@mattyr I think the patch is good enough for now.

@MikeMcQuaid
Copy link
Member

I'll dehackify this and push something later today.

@MikeMcQuaid
Copy link
Member

And thanks!

@mattyr
Copy link
Author

mattyr commented Jul 27, 2012

@MikeMcQuaid No problem!

@MikeMcQuaid
Copy link
Member

Pushed a new version with Webkit, no X11 dependency and bottle in 2547ffd.

@shigeya
Copy link
Contributor

shigeya commented Jul 27, 2012

thanks guys. now, I migrate other Macs to Mountain Lion:)

fgeller pushed a commit to fgeller/homebrew that referenced this pull request Aug 22, 2012
Sharpie pushed a commit to Sharpie/homebrew that referenced this pull request Sep 12, 2012
snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012
@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants