putty install incomplete #44622
Comments
|
It seems that the |
|
?! if putty itself doesn't build, then 2 questions:
|
|
The |
|
The other binaries exist only to support putty. In other words if you don't get putty, these binaries are useless (for the most part). I'm trying to understand the point of this - I'm obviously missing something. |
|
OK... I guess you are saying that |
|
Yeah, |
|
Does that make sense to you... putty without putty? |
|
I think pscp, pftp, and plink are still useful, so I think we should not boneyard the formula, and I think putty is still the right name for the formula. We could add a caveat explaining why the GUI isn't included. |
|
I don't know what that use would be, but if someone finds it useful... |
For FontForge, where we stopped shipping the GUI as a result of the same set of changes that killed off As for the upstream situation, they recently switched to using GTK+3 in git which when released should make restoring the |
@seamusdemora Perhaps you could try? Otherwise, per @DomT4's feedback above, would suggest we just wait for a new release and close this. |
|
This actually works in terms of build (Notice the diff --git a/Library/Formula/putty.rb b/Library/Formula/putty.rb
index d03f3f7..45eee9e 100644
--- a/Library/Formula/putty.rb
+++ b/Library/Formula/putty.rb
@@ -21,9 +21,11 @@ class Putty < Formula
depends_on "halibut" => :build
depends_on "autoconf" => :build
depends_on "automake" => :build
+ depends_on "gtk+3" => :optional
end
depends_on "pkg-config" => :build
def install
if build.head?
@@ -37,17 +39,24 @@ class Putty < Formula
--disable-silent-rules
--disable-dependency-tracking
--disable-gtktest
- --without-gtk
]
+ if build.head? && build.with?("gtk+3")
+ args << "--with-gtk=3" << "--without-quartz"
+ else
+ args << "--without-gtk"
+ end
+
system "./configure", *args
build_version = build.head? ? "git-#{version}" : version
system "make", "VER=-DRELEASE=#{build_version}"
+ bin.install %w[putty puttytel pterm] if build.head? && build.with?("gtk+3")
bin.install %w[plink pscp psftp puttygen]
cd "doc" do
+ man1.install %w[putty.1 puttytel.1 pterm.1] if build.head? && build.with?("gtk+3")
man1.install %w[plink.1 pscp.1 psftp.1 puttygen.1]
end
end |
|
Dropped the dev an email regarding the segfault. Got a reply. Possibly related to our very new GTK+3 version and some deprecations around that, but he's open to fixes:
The line about the Quartz backend is interesting because I thought GTK+3 had killed that, and if you don't pass that option it dies during configure looking for |
|
For anyone curious, the referenced backtrace: |
|
I cloned the putty repository and managed to get the master branch compiling and running properly: no segfault when I launched putty and I managed to make a connection to an SSH server. I had to make the following changes to configure.ac: diff --git a/configure.ac b/configure.ac
index 82fae26..9cb517f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -97,22 +97,6 @@ case "$gtk_version_desired:$gtk" in
;;
esac
-case "$gtk_version_desired:$gtk" in
- 1:none | any:none)
- ifdef([AM_PATH_GTK],[
- AM_PATH_GTK([1.2.0], [gtk=1], [])
- ],[
- # manual check for gtk1
- AC_PATH_PROG(GTK1_CONFIG, gtk-config, absent)
- if test "$GTK1_CONFIG" != "absent"; then
- GTK_CFLAGS=`"$GTK1_CONFIG" --cflags`
- GTK_LIBS=`"$GTK1_CONFIG" --libs`
- gtk=1
- fi
- ])
- ;;
-esac
-
AM_CONDITIONAL(HAVE_GTK, [test "$gtk" != "none"])
if test "$gtk" = "2" -o "$gtk" = "3"; then
@@ -170,7 +154,7 @@ AS_IF([test AS_VAR_GET(x_cv_linux_so_peercred) = yes],
if test "x$GCC" = "xyes"; then
:
- AC_SUBST(WARNINGOPTS, ['-Wall -Werror'])
+ AC_SUBST(WARNINGOPTS, [])
else
:
AC_SUBST(WARNINGOPTS, [])The first part is necessary because I don't have gtk+1 installed (no one should be expected to do that nowadays anyway) and the second part is necessary because Afterwards I ran configure as: ./configure --with-gtk=3 --disable-gtktest --with-quartzThe |
|
Guys! Hello to everyone. |
|
I recommend you use Cyberduck until a new version of Putty is released that supports |
|
@tschoonj Upstream may well take your patch if you submit it to them. They were interested in getting that fixed. |
|
I doubt they would accept my patch: I think they explicitly want to keep the gtk+1 support |
|
This should work now, per local testing. brew update && brew install putty --HEAD --with-gtk+3 |
|
This is happening again with the latest HEAD $ brew update && brew install putty --HEAD --wth-gtk+3 |
|
Theres a typo in your command. Try |
|
ha ha, whoops. Cheers! |
|
Now the build fails with the following error: Installed packages: |
|
Should I report it to https://github.com/Homebrew/homebrew-core? |
|
Reported: Homebrew/homebrew-core#1078. |
'brew install putty' creates several binaries in /usr/local/Cellar/putty/0.65/bin
However, putty itself is not one of them
The text was updated successfully, but these errors were encountered: