Putty build failure with GTK+3 and HEAD #1078
Comments
|
Either way, even when it is present, there is no need to assume that an app bundle would be a desirable outcome anyway, especially when using Homebrew to build it! I suggest you file a bug over this on the putty website. |
1 similar comment
|
Either way, even when it is present, there is no need to assume that an app bundle would be a desirable outcome anyway, especially when using Homebrew to build it! I suggest you file a bug over this on the putty website. |
|
Thanks. An email sent to the PuTTY team. |
|
My request and Simon Tatham's response:
|
|
CC @tschoonj for our resident GTK expert's thoughts. |
Is Simon aware this is only offered as a |
|
I've been thinking about adding a formula for Edit - Excuse the close/open below, bonked the wrong button. |
|
Well Simon has a good point obviously as he cannot be expected to ensure master works perfectly fine at any given moment. @yan12125 Would you be willing to provide a patch to Putty to fix this? @DomT4 Not sure if adding a formula for |
I guess not as I didn't clearly state it in the first mail. Sent another mail.
I'm afraid not as I can't understand the format of PuTTY's diff --git a/Formula/putty.rb b/Formula/putty.rb
index eff9cac..952856b 100644
--- a/Formula/putty.rb
+++ b/Formula/putty.rb
@@ -22,6 +22,8 @@ class Putty < Formula
depends_on "autoconf" => :build
depends_on "automake" => :build
depends_on "gtk+3" => :optional
+
+ patch :DATA
end
depends_on "pkg-config" => :build
@@ -78,3 +80,27 @@ class Putty < Formula
assert File.exist?("test.key")
end
end
+__END__
+diff --git a/Recipe b/Recipe
+index 68726a0..cc379b5 100644
+--- a/Recipe
++++ b/Recipe
+@@ -183,18 +183,6 @@ install-exec-local:
+ endif
+ !end
+
+-# In automake makefile, build the OS X app bundle, if configured in
+-# Quartz mode.
+-!begin am
+-if HAVE_QUARTZ
+-noinst_SCRIPTS = unix/PuTTY.app unix/Pterm.app
+-unix/PuTTY.app: unix/putty.bundle puttyapp osxlaunch
+- rm -rf $@ && gtk-mac-bundler $<
+-unix/Pterm.app: unix/pterm.bundle ptermapp osxlaunch
+- rm -rf $@ && gtk-mac-bundler $<
+-endif
+-!end
+-
+ # Random symbols.
+ !begin cygwin vars
+ # _WIN32_IE is required to expose identifiers that only make sense on |
Can you elaborate here a bit? |
|
Get no response from Simon since then. How about just applying my previous patch in Homebrew? |
|
You can try, but patching HEAD seems like a dangerous thing to do. |
|
Patching HEAD seems like a bad idea, we should just remove it and add a comment explaining why it was removed. |
Sorry, but remove what? |
|
|
|
Go ahead. I've found another serial port client. |
Please follow the general troubleshooting steps first:
brew updateand retried your prior step?brew doctor, fixed as many issues as possible and retried your prior step?sudo chown -R $(whoami) $(brew --prefix)?Bug reports:
doctor's diagnosis:
Build log:
The text was updated successfully, but these errors were encountered: