Exclude casks when determining dependants #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 6, 2020
|
Okay, this is no longer needed to fix CI, but I still think it's a good idea (assuming that Homebrew/brew#9437 is merged). It may help to stop this issue from re-occurring in the future. |
MikeMcQuaid
approved these changes
Dec 7, 2020
|
✅ once/if Homebrew/brew#9437 is merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only include formula dependents when determining which formulae to test. This solves the problems we've seen in Homebrew/homebrew-core#66268 and Homebrew/homebrew-core#66287.
This can't be merged until Homebrew/brew#9437 is merged (which is what adds the
--formulaand--caskargs tobrew uses