Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cryptography 3.4.x resources #91536

Closed
wants to merge 9 commits into from
Closed

Conversation

alex
Copy link
Contributor

@alex alex commented Dec 17, 2021

This ensures that all brew packages use the latest version in the 3.4.x series

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added automerge-skip `brew pr-automerge` will skip this pull request python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue labels Dec 17, 2021
@alex alex force-pushed the bump-cryptography branch from c2e8193 to 8b706da Compare December 17, 2021 23:37
@Bo98
Copy link
Member

Bo98 commented Dec 17, 2021

charm-tools might fail because it might need juju/charm-tools#611 (I can handle it in a separate PR). Rest should be good.

@Bo98 Bo98 added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Dec 17, 2021
@alex
Copy link
Contributor Author

alex commented Dec 17, 2021

Thanks! Happy to rebase when that happens.

(I'm one of the cryptography maintainers and I want to move the ecosystem to using the latest releases and getting to the latest within a version is the starting point.)

@carlocab carlocab removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 19, 2021
@alex
Copy link
Contributor Author

alex commented Dec 19, 2021

Looks like CI timed out despite the labels (perhaps they were added after the job started?)

@alex alex force-pushed the bump-cryptography branch from 8b706da to 3c9f075 Compare December 24, 2021 15:26
@BrewTestBot BrewTestBot removed the automerge-skip `brew pr-automerge` will skip this pull request label Dec 24, 2021
@alex alex force-pushed the bump-cryptography branch 3 times, most recently from c88d1a9 to 0c85d96 Compare December 30, 2021 00:38
@alex
Copy link
Contributor Author

alex commented Dec 30, 2021

Tests appear to be passing now, just timing out on some of the builders.

@carlocab carlocab added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 30, 2021
@alex alex force-pushed the bump-cryptography branch from 0c85d96 to 98dc809 Compare December 30, 2021 20:20
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@alex alex deleted the bump-cryptography branch December 31, 2021 13:32
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 31, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. outdated PR was locked due to age python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants