Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nbdime 3.1.1 #86629

Closed
wants to merge 1 commit into from
Closed

nbdime 3.1.1 #86629

wants to merge 1 commit into from

Conversation

branchvincent
Copy link
Member

nbdime: migrate to python@3.10

@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Oct 6, 2021
@Moisan
Copy link
Member

Moisan commented Oct 16, 2021

Fails in setup.py because 3.10 < 3.6 😢

    File "setup.py", line 26, in <module>
      ensure_python('>=3.6')
    File "/private/tmp/pip-req-build-21k7anrz/setupbase.py", line 109, in ensure_python
      raise ValueError('Python version %s unsupported' % part)
  ValueError: Python version 3.10 unsupported

@cclauss
Copy link
Contributor

cclauss commented Oct 26, 2021

Fixed in jupyter/nbdime#607 and landed in v3.1.1 https://pypi.org/project/nbdime

@branchvincent branchvincent changed the title nbdime: migrate to python@3.10 nbdime 3.1.1 Oct 26, 2021
@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 26, 2021
chenrui333
chenrui333 previously approved these changes Oct 26, 2021
View reviewed changes
@SMillerDev
Copy link
Member

This needs to be rebased

@Moisan Moisan added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Oct 27, 2021
Moisan
Moisan previously approved these changes Oct 28, 2021
View reviewed changes
iMichka
iMichka previously approved these changes Oct 28, 2021
View reviewed changes
@iMichka iMichka removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 28, 2021
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ Bottle publish failed.

@BrewTestBot BrewTestBot dismissed stale reviews from Moisan and iMichka October 28, 2021 20:12

bottle publish failed

@iMichka iMichka added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 28, 2021
@BrewTestBot
Copy link
Member

:shipit: @iMichka has triggered a merge.

@branchvincent
Copy link
Member Author

thanks @cclauss for your help both here and in other PR's, much appreciated! 🍻

@branchvincent branchvincent deleted the python@3.10-nbdime branch October 28, 2021 20:56
@cclauss
Copy link
Contributor

cclauss commented Oct 31, 2021

Still 19 left... https://github.com/Homebrew/homebrew-core/labels/python-3.10-migration Is there anything that I can do on those repos to help close any of the 19?

@iMichka
Copy link
Member

iMichka commented Oct 31, 2021

Check the logs, see if anything can be fixed right away or if a patch is needed. Open a pull request upstream if possible. We will need to go through the list one by one.

@github-actions github-actions bot added the outdated PR was locked due to age label Dec 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Moisan Moisan Moisan left review comments

@chenrui333 chenrui333 chenrui333 left review comments

@iMichka iMichka iMichka left review comments

Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. outdated PR was locked due to age python Python use is a significant feature of the PR or issue python-3.10-migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@branchvincent @Moisan @cclauss @SMillerDev @BrewTestBot @iMichka @chenrui333