harmony-one 4.2.1 (new formula) #85856
Conversation
BrewTestBot
added
go
cylim
force-pushed
the
new/harmony-one
branch
from
1f2709e to
30f9184
Compare
Formula/harmony-one.rb
Outdated
| sha256 "d29609a99a3a2e9031d2a26414ffdc3e271c3bf9cf9331dfcb321715fef682d4" | ||
| license "LGPL-3.0-or-later" | ||
|
|
||
| depends_on "go@1.16" => :build |
There was a problem hiding this comment.
Why doesn't it work with the latest Go?
There was a problem hiding this comment.
probably golang/go#46645 issue. Will try to get the team to upgrade. 😄
Formula/harmony-one.rb
Outdated
|
|
||
| depends_on "go@1.16" => :build | ||
|
|
||
| depends_on arch: :x86_64 |
There was a problem hiding this comment.
Why doesn't it work on new macs?
There was a problem hiding this comment.
I will try to debug this after I solved the linux build issues. It was failing in the CI and I can't test it without M1 device. :)
Formula/harmony-one.rb
Outdated
| ENV["GOPATH"] = buildpath | ||
| ENV["GO111MODULE"] = "auto" |
There was a problem hiding this comment.
This shouldn't be needed in modern software.
There was a problem hiding this comment.
GOPATH is needed due to it is using in the Makefile to reference to other resources that had included in the file.
Formula/harmony-one.rb
Outdated
| <<~EOS | ||
| Invoke 'hmy cookbook' for examples of the most common, important usages | ||
| To gerenate docs in your current directories, run: 'hmy docs' | ||
| EOS |
There was a problem hiding this comment.
This should be in the upstream documentation, it's not homebrew specific.
There was a problem hiding this comment.
I will remove it in next force push. Thanks for letting me knows. 😄
Formula/harmony-one.rb
Outdated
|
|
||
| on_linux do | ||
| depends_on "gcc" | ||
| depends_on "glibc" |
There was a problem hiding this comment.
Why? Does this software really need latest glibc?
There was a problem hiding this comment.
The software doesn't need the latest.
I just figured out that Homebrew for Linux required those dependencies too, I had removed it from my local repo, but haven't hard push yet.
I am waiting for other fixes, then hard push at once. 😄
cylim
force-pushed
the
new/harmony-one
branch
from
30f9184 to
790b369
Compare
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?