Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charm-tools: add missing dep wheel, update license #70950

Closed
wants to merge 1 commit into from
Closed

charm-tools: add missing dep wheel, update license #70950

wants to merge 1 commit into from

Conversation

vvvvv
Copy link
Contributor

@vvvvv vvvvv commented Feb 11, 2021

brew install --build-from-source charm-tools failled to build.
Further investigation showed that dependency jsonschema needed wheel pkg installed.

Processing /private/tmp/charm-tools--jsonschema-20210211-36312-hkfrc1/jsonschema-2.5.1
[...]
      ERROR: Command errored out with exit status 1:
       command: /usr/local/Cellar/charm-tools/2.7.8/libexec/bin/python3.8 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/tmp/pip-wheel-2ie24vr6/vcversioner/setup.py'"'"'; __file__='"'"'/private/tmp/pip-wheel-2ie24vr6/vcversioner/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /private/tmp/pip-wheel-yc1xtp0n
           cwd: /private/tmp/pip-wheel-2ie24vr6/vcversioner/
      Complete output (6 lines):
      usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
         or: setup.py --help [cmd1 cmd2 ...]
         or: setup.py --help-commands
         or: setup.py cmd --help

      error: invalid command 'bdist_wheel'

I don't know why this did build before but I suspect wheel was by default installed into the virtualenv alongside setuptools etc.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot BrewTestBot added no ARM bottle Formula has no ARM bottle python Python use is a significant feature of the PR or issue labels Feb 11, 2021
@vvvvv vvvvv mentioned this pull request Feb 11, 2021
5 tasks
@carlocab
Copy link
Member

carlocab commented Feb 11, 2021

Thanks again for your help, @vvvvv.

FYI, for your future PRs, please homebrew/core style when writing commit message headings. We put the name of the formula first. [Ref] For example, yours would've been something like

charm-tools: add missing wheel dependency, update license

@carlocab carlocab changed the title missing dep wheel resulted in build error, updated license charm-tools: add missing dep wheel, update license Feb 11, 2021
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vvvvv ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot
Copy link
Member

@carlocab bottle request for charm-tools failed.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 15, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no ARM bottle Formula has no ARM bottle outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants