Don't skip the postinstall for CI #70494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not a great way to switch behavior, as it means that for example any usage in Actions of Homebrew to test on MacOS leads to unexpected and confusing behavior. See also #70493 for the rationale here.
carlocab
requested changes
Feb 5, 2021
There was a problem hiding this comment.
If we remove this, we need a way to avoid CI failures when this is tested simultaneously with mariadb or other mysql versions.
See #70493 (comment)
|
Oh, and please use homebrew/core style in your commit messages for future PRs:
Thanks for opening this! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a great way to switch behavior, as it means that for example any usage in Actions of Homebrew to test on MacOS leads to unexpected and confusing behavior.
See also #70493 for the rationale here.