asciiquarium: fix test logic

[iMichka]

• The stdin/sdtout variable names were inverted

• Fixes: Errno::EIO: Input/output error @ io_fread - /dev/pts/2 on linux

• Have you followed the guidelines for contributing?

• Have you checked that there aren't other open pull requests for the same formula update/change?

• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?

• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?

• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

[iMichka]

@homebrew/core I need help with PTY.spawn, does anyone have experience with this? It's not working correctly on 11.0 and 10.15. Can someone test the output there?

[carlocab]

I think it's broken:

❯ asciiquarium
[1]    22509 segmentation fault  asciiquarium

[carlocab]

asciiquarium is an env wrapper for a perl script. So here's what I tried:

❯ perl /usr/local/Cellar/asciiquarium/1.1_1/libexec/bin/asciiquarium
Can't locate Term/Animation.pm in @INC (you may need to install the Term::Animation module) (@INC contains: /usr/local/Cellar/perl/5.32.1/lib/perl5/site_perl/5.32.1/darwin-thread-multi-2level /usr/local/Cellar/perl/5.32.1/lib/perl5/site_perl/5.32.1 /usr/local/Cellar/perl/5.32.1/lib/perl5/5.32.1/darwin-thread-multi-2level /usr/local/Cellar/perl/5.32.1/lib/perl5/5.32.1 /usr/local/lib/perl5/site_perl/5.32.1) at /usr/local/Cellar/asciiquarium/1.1_1/libexec/bin/asciiquarium line 42.
BEGIN failed--compilation aborted at /usr/local/Cellar/asciiquarium/1.1_1/libexec/bin/asciiquarium line 42.

That said, I don't know perl, so that may not have even been the right thing to do. Same error if I use /usr/bin/perl.

Ah, wait, no:

❯ export PERL5LIB="/usr/local/Cellar/asciiquarium/1.1_1/libexec/lib/perl5"
❯ /usr/bin/perl /usr/local/Cellar/asciiquarium/1.1_1/libexec/bin/asciiquarium
[1]    23421 segmentation fault  /usr/bin/perl /usr/local/Cellar/asciiquarium/1.1_1/libexec/bin/asciiquarium

[iMichka]

I think I know what to do, I need to vendor that library. W do that with other perl formulae. Let me try that.

EDIT: actually it's already vendored.

[carlocab]

If I stick it in lldb:

❯ lldb /usr/bin/perl
(lldb) target create "/usr/bin/perl"
Current executable set to '/usr/bin/perl' (x86_64).
(lldb) env PERL5LIB="/usr/local/Cellar/asciiquarium/1.1_1/libexec/lib/perl5"
(lldb) run /usr/local/Cellar/asciiquarium/1.1_1/libexec/bin/asciiquarium
error: process exited with status -1 (attach failed (Not allowed to attach to process.  Look in the console messages (Console.app), near the debugserver entries when the attached failed.  The subsystem that denied the attach permission will likely have logged an informative message about why it was denied.))

Console log:
crash.tar.gz

[mitchblank]

@iMichka / @carlocab -- you might take a look at my previous attempt to fix this formula: #66485

I had it working on my 11.0 box but had issues getting CI to pass. Ultimately the PR never got merged. Maybe you fixed the test issue now and just need to integrate those other fixes?

[iMichka]

@mitchblank I added your workaround but it still does not work. At this point I think I will disable the formulae for the broken macOS versions.

[mitchblank]

It's a bit unfortunate since the package itself seems to build/run/test fine locally for me (at least after the changes I made) . Shame that the CI system has some problem with some formulae these days...

Or are you seeing the same failure that @carlocab was? On which OS?

[nandahkrishna]

@iMichka could you check if this is alright? Just took a shot with a very minor tweak and it seems to have worked.

[carlocab]

I think @iMichka will be happy to take any fix here. 😄

[iMichka]

Nice work. So it just missed a "q" to quit the process. People will be happy to get the fishes back on their screens :)

[BrewTestBot]

@iMichka has triggered a merge.