Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airshare: fix test #69823

Closed

Conversation

nandahkrishna
Copy link
Member

@nandahkrishna nandahkrishna commented Jan 26, 2021

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

The airshare formula was building correctly and tests were okay locally as per this comment, however the bottle step failed because of ports being inaccessible in the CI environment.

This PR aims to fix this issue and correct a usage inaccuracy in the previous test. The test proposed here is modelled after the one in ninja.

@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Jan 26, 2021
@nandahkrishna nandahkrishna deleted the fix-airshare-test branch January 26, 2021 23:15
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 26, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants