Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ponyc 0.38.2 #67765

Closed
wants to merge 1 commit into from
Closed

Conversation

chenrui333
Copy link
Member

Created with brew bump-formula-pr.

@chenrui333 chenrui333 added 11 Big Sur is specifically affected test failure CI fails while running the test-do block labels Dec 26, 2020
@carlocab
Copy link
Member

Related: #66450

@chenrui333
Copy link
Member Author

looks interesting, specially considering their 0.38.2 release is to fix big sur linking issue.

@carlocab
Copy link
Member

That is quite weird. Actually, I just tried testing the old version of ponyc locally. I can make the test succeed in the shell if I add the flag

--linker="ld -L/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/lib"

to the test. It fails when I add this to the formula and run brew test though.

Ref. ponylang/ponyc#3684

@chenrui333
Copy link
Member Author

yeah, I saw that issue, I thought the change was supposed to be released part of 0.38.2 :(

@chenrui333 chenrui333 added the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label Dec 27, 2020
@carlocab
Copy link
Member

carlocab commented Dec 27, 2020

I thought the change was supposed to be released part of 0.38.2

Me too. Though maybe I'm thinking the test failure may have more to do with the brew test environment since I think the important change from 0.38.2 is that they now add those linker flags by default. Adding the linker flags works in the shell, but not in brew test.

@chenrui333
Copy link
Member Author

chenrui333 commented Jan 3, 2021

deprecate pony-stable, #68201

@chenrui333
Copy link
Member Author

@carlocab I think we are good with the merge(only pony-stable test failure on 11.0, and it can be deprecated as the upstream no longer support it), what do you think?

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically deprecated formulae should still be working... but not sure there’s much point trying to fix pony-stable now, so LGTM

@BrewTestBot
Copy link
Member

:shipit: @chenrui333 has triggered a merge.

@chenrui333
Copy link
Member Author

Thanks! merging the PR. :)

@chenrui333 chenrui333 removed test failure CI fails while running the test-do block CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. 11 Big Sur is specifically affected labels Jan 3, 2021
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 3, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 3, 2021
@chenrui333 chenrui333 deleted the bump-ponyc-0.38.2 branch December 18, 2022 05:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants