Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libnetworkit, networkit 8.0 #67184

Closed
wants to merge 4 commits into from

Conversation

chenrui333
Copy link
Member

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Dec 18, 2020
@chenrui333 chenrui333 added the test failure CI fails while running the test-do block label Dec 18, 2020
@chenrui333 chenrui333 changed the title networkit 8.0 libnetworkit, networkit 8.0 Dec 19, 2020
@chenrui333 chenrui333 added the 11 Big Sur is specifically affected label Dec 19, 2020
Formula/networkit.rb Outdated Show resolved Hide resolved
@chenrui333 chenrui333 added CI-requeued PR has been re-added to the queue and removed 11 Big Sur is specifically affected test failure CI fails while running the test-do block labels Dec 27, 2020
@chenrui333
Copy link
Member Author

still the same error.

  BuildError: Failed executing: /usr/local/opt/python@3.9/bin/python3 -c import\ networkit\ as\ nk
G\ =\ nk.graph.Graph(3)
G.addEdge(0,1)
G.addEdge(1,2)
G.addEdge(2,0)
assert\ G.degree(0)\ ==\ 2
assert\ G.degree(1)\ ==\ 2
assert\ G.degree(2)\ ==\ 2

@chenrui333 chenrui333 added 11 Big Sur is specifically affected test failure CI fails while running the test-do block labels Dec 27, 2020
@chenrui333
Copy link
Member Author

Since networkit bottling issue is already tracked in here, I think we can merge this PR as it is.

@fabratu
Copy link
Contributor

fabratu commented Jan 4, 2021

Thanks @chenrui333 @SMillerDev for the help updating the package. As the maintainer of the first version of the package I can confirm the reason behind using github repo instead of the archive. Also confirmed: the suggested change works with the underlying build-system. There are plans to change the detection of tlx in a future update of networkit - in which case I will also post an update here.

As for 11.0. I tested the PR locally with 11.1 on Intel Kabylake. No problems there:

Test command:

❯ brew test-bot --only-formulae networkit
==> Using Homebrew/homebrew-test-bot 138ab86 (Merge pull request #548 from Homebrew/dependabot/bundler/rspec-mocks-3.10.1)
==> Testing Homebrew/brew 2.7.1-119-g4a90a5a5d (Merge pull request #10199 from reitermarkus/check-https-content)
==> Using Homebrew/homebrew-core 39af1529f3 (awsweeper: update 0.11.1 bottle.)

==> Running Formulae#detect_formulae!
    url             (undefined)
    origin/master   (undefined)
    HEAD            (undefined)
    diff_start_sha1 39af1529f356db9c9b20409e24ed763d8950f960
    diff_end_sha1   39af1529f356db9c9b20409e24ed763d8950f960
==> Testing Formula changes:
    added    (empty)
    modified (empty)
    deleted  (empty)

==> Running Formulae#formula!(networkit)
==> Determining dependencies...
==> brew link libnetworkit
==> brew fetch --retry swig
==> Determining dependents...
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance
==> Starting build of networkit
==> brew fetch --retry networkit --build-bottle
==> brew uninstall --force networkit
==> brew install --only-dependencies --verbose --build-bottle networkit
==> brew install --verbose --build-bottle networkit
==> brew audit networkit --online --git --skip-style
==> brew bottle --verbose --json networkit
==> brew bottle --merge --write --no-commit ./networkit--8.0.big_sur.bottle.json
==> brew uninstall --force networkit
==> brew uninstall --force swig
==> brew install --only-dependencies ./networkit--8.0.big_sur.bottle.tar.gz
==> brew install ./networkit--8.0.big_sur.bottle.tar.gz
==> brew linkage --test networkit
==> brew install --only-dependencies --include-test networkit
==> brew test --verbose networkit
All steps passed!

OS-version:

system_profiler SPSoftwareDataType
Software:

    System Software Overview:
      System Version: macOS 11.1 (20C69)
    ...

CPU:

sysctl -n machdep.cpu.brand_string
Intel(R) Core(TM) i5-7267U CPU @ 3.10GHz

@chenrui333
Copy link
Member Author

@fabratu 👋 thanks for testing out the formula on 11.0.

As the maintainer of the first version of the package I can confirm the reason behind using github repo instead of the archive.

Can you elaborate a bit on why using tag/revision vs tarball file?

@chenrui333
Copy link
Member Author

rebased to latest master and have another run.

@SeekingMeaning SeekingMeaning removed 11 Big Sur is specifically affected CI-requeued PR has been re-added to the queue test failure CI fails while running the test-do block labels Jan 26, 2021
@SeekingMeaning
Copy link
Contributor

networkit/networkit#666 😈

@SeekingMeaning SeekingMeaning added the ready to merge PR can be merged once CI is green label Jan 26, 2021
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 26, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 26, 2021
@chenrui333 chenrui333 deleted the bump-networkit-8.0 branch December 18, 2022 05:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants