Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost 1.75 #66792

Closed
wants to merge 20 commits into from
Closed

boost 1.75 #66792

wants to merge 20 commits into from

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Dec 12, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Update

Formula CI Failure Version Status
cucumber-cpp test 10.14 Unable to install Ruby Gems, cf #66450
boost-python test 10.15,11.0 Not due to boost version bump, see below

boost-python doesn't have a Big Sur bottle (#65000), so I suspect this just isn't compatible with Xcode 12.

I verified this by testing boost-python against the existing boost formula (pre-version bump) on a GitHub macOS 10.15 runner here: https://github.com/carlocab/homebrew-personal/pull/21/checks?check_run_id=1580808244

The reported error is the same, so the boost-python breakage is not due to the boost version bump.

Non-deterministic Failures (CI-induced?)

These failures sometimes emerge, and sometimes don't. I suspect they are mariadb-type CI failures (ref #66450).

Formula CI Failure Version Error Message
cucumber-cpp test 10.15,11.0 Unable to contact the wire server at localhost:3902.
freeling bottle 11.0 gzip: write: No space left on device
widelands install --build-bottle 11.0 Write failed

For example, in this test run cucumber-cpp errored for 11.0 but not for 10.15. It errored out for both versions with the same error in the previous run. (Neither produced errors on the third-to-the-last run.)

See also fn and frugal failures at #66355.

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Dec 12, 2020
@SMillerDev SMillerDev changed the title boost 1.7.5 boost 1.75 Dec 12, 2020
@carlocab

This comment has been minimized.

@carlocab

This comment has been minimized.

@carlocab

This comment has been minimized.

@carlocab

This comment has been minimized.

@carlocab

This comment has been minimized.

@carlocab

This comment has been minimized.

@carlocab carlocab force-pushed the bump-boost-1.7.5 branch 2 times, most recently from e9175c1 to ce3dc4e Compare December 12, 2020 20:03
@carlocab
Copy link
Member Author

10.14:

Error: 6 failed steps!
brew test --retry --verbose cucumber-cpp
brew fetch --retry mapnik
brew test --verbose libbitcoin-protocol
brew test --verbose libbitcoin-client
brew test --verbose libbitcoin-explorer
brew test --verbose libbitcoin-server

10.15, 11.0:

Error: 7 failed steps!
brew test --retry --verbose cucumber-cpp
brew fetch --retry mapnik
brew test --verbose libbitcoin-protocol
brew test --verbose libbitcoin-client
brew test --verbose boost-python
brew test --verbose libbitcoin-explorer
brew test --verbose libbitcoin-server

@carlocab
Copy link
Member Author

10.14:

Error: 2 failed steps!
brew fetch --retry mapnik
brew test --verbose cucumber-cpp

Ok, guess I wasn't able to fix cucumber-cpp.

@carlocab
Copy link
Member Author

This is the boost-python error:

==> python
Traceback (most recent call last):
  File "<stdin>", line 2, in <module>
ImportError: dlopen(./hello.so, 2): no suitable image found.  Did find:
	file system relative paths not allowed in hardened programs

@carlocab carlocab force-pushed the bump-boost-1.7.5 branch 3 times, most recently from 6bbf2f0 to 4143b16 Compare December 15, 2020 17:37
Formula/boost-python.rb Outdated Show resolved Hide resolved
@carlocab carlocab force-pushed the bump-boost-1.7.5 branch 5 times, most recently from 97b6c38 to def6355 Compare December 16, 2020 18:59
@carlocab
Copy link
Member Author

Ok, I don't get why cucumber-cpp got broken on 10.15 and 11.0 again. It already tested fine on those versions on the last full testing run.

@carlocab
Copy link
Member Author

I think this might be ready, @fxcoudert. Test result summary in the first post.

@carlocab
Copy link
Member Author

On a separate note, is there a way to specify depends_on xcode but requiring a maximum xcode version? Because I think that's what boost-python needs.

@fxcoudert fxcoudert closed this in 5995207 Dec 19, 2020
@fxcoudert
Copy link
Member

Thanks @carlocab, merged!
I think we could do a maximum Xcode version with fails_with

@carlocab
Copy link
Member Author

Huh, I thought fails_with was just for build requirements. Let me look into it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants