Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtorch 1.7.1 + torchvision 0.8.2 #66688

Closed
wants to merge 2 commits into from

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Dec 10, 2020

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Dec 10, 2020
chenrui333
chenrui333 previously approved these changes Dec 11, 2020
@carlocab
Copy link
Member Author

carlocab commented Dec 11, 2020

Looks like torchvision needs a revision bump:

==> brew linkage --test torchvision
==> FAILED
Broken dependencies:
  /usr/local/opt/python@3.9/Frameworks/Python.framework/Versions/3.9/Python (python@3.9)

This also explains the later test failure. (This is the only failure on 10.14.)

If someone wants to add a commit to this PR doing that, please go ahead. My Mac is currently unusable from trying to build Rust. Never mind, found a way.

@carlocab
Copy link
Member Author

Sorted it out. Thanks for the help anyway, @chenrui333!

@chenrui333 chenrui333 added the test failure CI fails while running the test-do block label Dec 11, 2020
@carlocab
Copy link
Member Author

Oh, I see the problem. torchvision needs a version bump: https://github.com/pytorch/vision/releases.

I'll get to that.

@carlocab carlocab force-pushed the bump-libtorch-1.7.1 branch from 97378a7 to 9010692 Compare December 11, 2020 04:53
@carlocab carlocab changed the title libtorch 1.7.1 libtorch 1.7.1 + torchvision 0.8.2 Dec 11, 2020
@carlocab
Copy link
Member Author

Still the same error after the version bump. How annoying.

@carlocab

This comment has been minimized.

@carlocab
Copy link
Member Author

carlocab commented Dec 11, 2020

Ok, I can't reproduce this error locally. Could this be a CI problem? No, just a not-reading-the-formula-carefully-enough problem.

@gromgit
Copy link
Member

gromgit commented Dec 11, 2020

This:

==> brew linkage --test torchvision
==> FAILED
Broken dependencies:
  /usr/local/opt/python@3.9/Frameworks/Python.framework/Versions/3.9/Python (python@3.9)

probably means that python@3.9 should be a general dependency in torchvision, not just a build one.

- Add python@3.9 as a runtime dependency. Linkage test fails without it.
@carlocab carlocab force-pushed the bump-libtorch-1.7.1 branch from 9010692 to 1d310fa Compare December 11, 2020 10:34
@carlocab carlocab requested a review from chenrui333 December 11, 2020 18:41
@chenrui333 chenrui333 removed the test failure CI fails while running the test-do block label Dec 11, 2020
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@carlocab carlocab deleted the bump-libtorch-1.7.1 branch December 11, 2020 19:28
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 11, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants