-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mariadb*: add deprecation information #66682
Conversation
In case you get weird CI errors (see last few posts): #66450 |
I'm wondering: Maybe it makes sense to do the same as with Python, where there is no That might simplify maintaining deprecation dates? |
All these test failures look like transient network errors. RE the failures in #66450, those seem to be caused by different forks of MySQL being tested in the same run. Uninstalling a database server doesn’t remove the database itself by design, and all the MySQL forks store the database in var/mysql. When you change forks, you end up trying to use an incompatible database. Those failures don’t appear in this test run because we’re testing different versions of the same fork. IMO, we should be using var/mariadb for the data files instead of var/mysql, with some means to migrate data files over automatically. I’m not an expert in MySQL, so there might be different problems with doing that. |
It's better not to do it if possible. We had to make it for python because there are too many dependents which we weren't able to migrate at once. |
This is fine, but it needs to be one commit per formula |
580b9ea
to
91c617a
Compare
I've clearly spent too much time working on single-commit, squash-and-merge PRs lately 🤦 I've rebased and separated this into individual commits. For what it's worth, the only reason why I omitted the |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?In researching why
10.1
releases ofmariadb
were removed from the first-party downloads page, I noticed that it had been recently deprecated as of 2020-10. As such, I added the deprecation information and removed thelivecheck
block (so it's appropriately skipped).The deprecation dates are mentioned on each major/minor release's "Changes and Improvements in MariaDB" page, so I also added deprecation information for the other versioned
mariadb
formulae.Currently the
mariadb
formula uses10.5
, which has a deprecation date of 2025-06 but I wasn't sure if we wanted to add this to the formula. On the one hand, when10.6
is released andmariadb.rb
is copied asmariadb@10.5.rb
, it would already have the correct deprecation date. On the other hand, the deprecation date in themariadb
formula would need to be kept up to date with the current major/minor release (or commented out until the formula is versioned).If we think that the
mariadb
formula should also have a deprecation date (for the former reason), then I'll update this PR accordingly.