Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portmidi: fix build on Big Sur #66648

Closed
wants to merge 1 commit into from

Conversation

mbcoguno
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

I figure out portmidi is MIT license, its SourceForge project page (https://sourceforge.net/projects/portmedia/) says it's MIT license, but its license file add additional sentence (https://sourceforge.net/p/portmedia/code/HEAD/tree/portmidi/trunk/license.txt) cause it looks like "Artistic-2.0". Right now I choose "MIT".

When building portmidi, it will build its tools that not include in install target. A tool "pmjni" required Java headers, and Big Sur drop JavaVM.framework cause build failure, add a patch to skip related tool to build. This patch should not affect dynamic library.

Also add a simple test.

* Add license.
* Add test.
@SMillerDev
Copy link
Member

I figure out portmidi is MIT license, its SourceForge project page (https://sourceforge.net/projects/portmedia/) says it's MIT license, but its license file add additional sentence (https://sourceforge.net/p/portmedia/code/HEAD/tree/portmidi/trunk/license.txt) cause it looks like "Artistic-2.0". Right now I choose "MIT".

Please ask for clarification upstream

@mbcoguno
Copy link
Contributor Author

Their related project, PortAudio, comes with same license text, and their webpage says "In terms of legal compatibility, the PortAudio licence is now a plain MIT licence". I think portmidi is also MIT license.
Anyway, I send an email to one of the portmidi's contributor about this, I will update if I get reply.

@mbcoguno
Copy link
Contributor Author

2020-12-10 23 44 11 mail protonmail com a4fb865d8df4

I think we can ignore the extra request to pick it's MIT.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 10, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants