-
-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python@3.9 3.9.1 #66489
python@3.9 3.9.1 #66489
Conversation
Haha, just beat me to it! |
The biggest thing off the top of my head is that there are some patches that may need to be removed. I haven't looked at the source to confirm, yet. |
Had a look at the patches; didn't seem like they needed to be removed based on the comments. Though perhaps I misunderstood/missed something. |
Oh, wait, I found it: https://github.com/python/cpython/commits/3.9?after=f0e42ae03c41ec32fcb3064772f46ff7f2c5ff3b+34&branch=3.9 Commits on 22 November. Looks like they've added Big Sur/ARM support, which means the first patch may need to be removed. Went ahead and removed it in a separate commit to make it easy to revert if needed. |
It looks to me like both patches can be removed. I know that FX's patch (the second one) from python/cpython#23622 has been applied in python/cpython@09a698b. The other one is longer so I haven't looked at it yet. Usually, though, the patch would fail to apply so we'd get a build error |
Yes, I see that commit in the history for 3.9 too. Removing the second patch. |
Just to note, |
Think it's worth holding off on/rerunning the Python tests till/when |
We have a bit of a backlog of formulas to retest, so I've killed testing. Let's redo it after Also: my patch from python/cpython#23556 was committed to the 3.9 branch, but did it make it into the 3.9.1 release? Can someone actually check that, please? |
@fxcoudert I believe it's the last commit (python/cpython@09a698b) listed on 3 December: https://github.com/python/cpython/commits/3.9?before=f0e42ae03c41ec32fcb3064772f46ff7f2c5ff3b+35&branch=3.9 |
@fxcoudert I'm pretty sure it is. Here's a direct link to a line modified by your commit on the 3.9.1 tag: https://github.com/python/cpython/blob/v3.9.1/Lib/distutils/spawn.py#L57-L58 |
More importantly, |
openssl 1.1.1i PR: #66501 |
a070dbc
to
d85525e
Compare
TL;DR No new failures so far. 10.14:
10.15:
|
11.0:
|
Created with
brew bump-formula-pr
.setuptools
bumped to 51.0.0Not sure if I'll manage to pull off this PR, but let's see.