Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python@3.9 3.9.1 #66489

Closed
wants to merge 1 commit into from
Closed

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Dec 8, 2020

Created with brew bump-formula-pr.

  • version bumped to 3.9.1
  • resource setuptools bumped to 51.0.0

Not sure if I'll manage to pull off this PR, but let's see.

@Rylan12
Copy link
Member

Rylan12 commented Dec 8, 2020

Haha, just beat me to it!

@Rylan12
Copy link
Member

Rylan12 commented Dec 8, 2020

The biggest thing off the top of my head is that there are some patches that may need to be removed. I haven't looked at the source to confirm, yet.

@carlocab
Copy link
Member Author

carlocab commented Dec 8, 2020

Had a look at the patches; didn't seem like they needed to be removed based on the comments. Though perhaps I misunderstood/missed something.

@carlocab
Copy link
Member Author

carlocab commented Dec 8, 2020

Oh, wait, I found it: https://github.com/python/cpython/commits/3.9?after=f0e42ae03c41ec32fcb3064772f46ff7f2c5ff3b+34&branch=3.9

Commits on 22 November. Looks like they've added Big Sur/ARM support, which means the first patch may need to be removed. Should I go ahead and do that, @Rylan12?

Went ahead and removed it in a separate commit to make it easy to revert if needed.

@Rylan12
Copy link
Member

Rylan12 commented Dec 8, 2020

It looks to me like both patches can be removed. I know that FX's patch (the second one) from python/cpython#23622 has been applied in python/cpython@09a698b.

The other one is longer so I haven't looked at it yet. Usually, though, the patch would fail to apply so we'd get a build error

@carlocab
Copy link
Member Author

carlocab commented Dec 8, 2020

Yes, I see that commit in the history for 3.9 too. Removing the second patch.

@sharris40
Copy link
Contributor

Just to note, readline is being updated simultaneously in #66472, but I doubt there will be any ABI breakage.

@carlocab
Copy link
Member Author

carlocab commented Dec 8, 2020

Think it's worth holding off on/rerunning the Python tests till/when readline is done?

@fxcoudert
Copy link
Member

We have a bit of a backlog of formulas to retest, so I've killed testing. Let's redo it after readline is merged.

Also: my patch from python/cpython#23556 was committed to the 3.9 branch, but did it make it into the 3.9.1 release? Can someone actually check that, please?

@carlocab
Copy link
Member Author

carlocab commented Dec 8, 2020

@Rylan12
Copy link
Member

Rylan12 commented Dec 8, 2020

@fxcoudert I'm pretty sure it is. Here's a direct link to a line modified by your commit on the 3.9.1 tag: https://github.com/python/cpython/blob/v3.9.1/Lib/distutils/spawn.py#L57-L58

@sharris40
Copy link
Contributor

We have a bit of a backlog of formulas to retest, so I've killed testing. Let's redo it after readline is merged.

More importantly, openssl also just updated upstream, so whenever somebody familiar with it makes a PR, this one should probably wait on that as well. Getting openssl patched is a bigger concern than Python.

@fxcoudert
Copy link
Member

openssl 1.1.1i PR: #66501

@carlocab
Copy link
Member Author

TL;DR No new failures so far.

10.14:

Error: 16 failed steps!
brew test --retry --verbose cargo-edit
brew test --retry --verbose cucumber-cpp
brew fetch --retry diff-pdf
brew test --retry --verbose glyr
brew test --retry --verbose hyperkit
brew fetch --retry mapnik
brew install mariadb
brew install mariadb@10.1
brew install mariadb@10.2
brew install mariadb@10.3
brew install mariadb@10.4
brew test --retry --verbose mysql@5.6
brew test --retry --verbose mysql@5.7
brew test --retry --verbose pcl
brew install percona-server
brew test --retry --verbose pipgrip

10.15:

Error: 14 failed steps!
brew test --retry --verbose cargo-edit
brew fetch --retry diff-pdf
brew test --retry --verbose glyr
brew test --retry --verbose hyperkit
brew fetch --retry mapnik
brew install mariadb
brew install mariadb@10.1
brew install mariadb@10.2
brew install mariadb@10.3
brew install mariadb@10.4
brew test --retry --verbose mysql@5.6
brew test --retry --verbose mysql@5.7
brew test --retry --verbose pcl
brew install percona-server

@carlocab
Copy link
Member Author

carlocab commented Dec 11, 2020

Some of these might be new, I'll need to check. These aren't the droids you're looking for. Move along.

11.0:

Error: 27 failed steps!
brew test --retry --verbose asuka
brew test --retry --verbose augustus
brew test --retry --verbose cargo-edit
brew test --retry --verbose corral
brew test --retry --verbose creduce
brew fetch --retry diff-pdf
brew install envoy
brew test --retry --verbose glyr
brew test --retry --verbose hyperkit
brew test --retry --verbose innotop
brew fetch --retry mapnik
brew install mariadb
brew install mariadb@10.1
brew install mariadb@10.2
brew install mariadb@10.3
brew install mariadb@10.4
brew test --retry --verbose mysql@5.6
brew test --retry --verbose mysql@5.7
brew test --retry --verbose networkit
brew install --only-dependencies oclgrind
brew install oclgrind
brew test --retry --verbose odin
brew test --retry --verbose pcl
brew install percona-server
brew test --retry --verbose pipgrip
brew test --retry --verbose pony-stable
brew test --retry --verbose ponyc

@BrewTestBot
Copy link
Member

:shipit: @fxcoudert has triggered a merge.

@carlocab carlocab deleted the bump-python@3.9-3.9.1 branch December 11, 2020 18:10
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 11, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants