python@3.9: find gdbm on ARM #66438
Merged
python@3.9: find gdbm on ARM #66438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I won't let the tests proceed to the end, I just want to check that this builds on all three macOS versions. I'll kill the tests, and merge without bottles. |
This was referenced Dec 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, python does not find gdbm.
Yes, I know superenv should take care of this, but python does not play too well with that. But due to the code at https://github.com/python/cpython/blob/29afab6c5f656f07ac85c9b2cf089631b2557a11/setup.py#L784 the python setup code actually records the directories passed as
-Iand-Loptions inCFLAGSandLDFLAGS. So we use those to allow detection ofgdbm, and possibly other things.Why did it work on Intel? Because Python adds
/usr/local/{include,lib}to its search paths anyway. But on ARM, we're not in those paths.