pod2man: change install location inside keg #66367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrewTestBot
added
the
missing license
This was referenced Dec 6, 2020
|
In general, this is why you don't why you do not want to be using I would highly recommend using |
mitchblank
force-pushed
the
pod2man-change-install-location
branch
from
bfef573 to
b21a379
Compare
5 tasks
chenrui333
added
the
CI-force-arm
|
@mitchblank can you do a rebase to trigger the arm build? Thanks! |
As discussed with Homebrew#66370 (comment) Big Sur's system perl changed how "PREFIX=" is treated as an install destination. The more explicit way to control MakeMaker is to set INSTALL_BASE instead, which should result in consistent behavior between different OS/X versions.
mitchblank
force-pushed
the
pod2man-change-install-location
branch
from
b21a379 to
6d7d219
Compare
|
Don't update this PR, though, as CI is fully backed up with revision bumps. It can wait till this one is merged. |
|
🤖 A scheduled task has triggered a merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating recent bottling failures and found that pod2man was failing due to
brew testfailing. The issue is that the test assumes that this (keg-only) formula installed its binary as.../Cellar/pod2man/4.14/bin/pod2textbut it was actually ending up at:
.../Cellar/pod2man/4.14/local/bin/pod2textI'm going to assume that
brew testworked at some point and that the former is the correct place to install it. Hopefully I'm right about that; I am no perl expert. It seems that if you specifyINSTALLDIRS=vendorwhen you build it that's what you get. Maybe the defaultINSTALLDIRSchanged at some point and broke this formula?cc @zachauten @mistydemeo