Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slrn: fix compile on Xcode 12 #66344

Closed
wants to merge 1 commit into from

Conversation

mitchblank
Copy link
Contributor

This is the usual story -- the fact that Xcode 12 now has -Werror,implicit-function-declaration as default causes an issue for the autoconf script. In this instance it causes the va_copy() details to be mis-detected which causes compile issues later.

I don't know how closely maintained this package is (the git repo has been quiet for a few years) but I have emailed a more complete fix to the maintainer. For the minute just using the simple workaround here.

@fxcoudert
Copy link
Member

Please file a report, open a ticket, or send an email to the devel list (and add a link in your comment). Otherwise we accumulate patches and fixes over time, and it becomes unmaintainable

@mitchblank
Copy link
Contributor Author

Please file a report, open a ticket, or send an email to the devel list (and add a link in your comment). Otherwise we accumulate patches and fixes over time, and it becomes unmaintainable

Per https://slrn.info/patches.html

When your patch has been tested and ready for submission I would suggest that the best place for submission would be directly to JED himself, see the email link at the base of this page

This is what I have done. I don't know if there is a better place to report issues on slrn -- the project doesn't seem to have a public bug tracker and its git is self-hosted. Emailing the maintainer seems the best available.

@BrewTestBot
Copy link
Member

:shipit: @fxcoudert has triggered a merge.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 6, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants