gptfdisk: fix compile on Big Sur #66304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Starting on 11.0, OS/X doesn't have physical files appearing as /usr/lib/*.dylib for the standard libraries, but the toolchain can still link against them (using the .tbd files inside the SDK to guide it) Just use "-lncurses" which seems to work. * "brew test" wouldn't work for me. The first problem was that hdiutil doesn't seem capable of creating a 128k disk image any more, but the command works when I run it manually with a 512k size. However, it still doesn't work due to a permission issue when running inside "brew test" -- I think something changed in how the test sandboxing works so that hdiutil can no longer run. (hdiutil can need expanded permissions since it temporarily mounts the new image I think) I couldn't find a clean way to work around it so I just changed the test to use this package itself to make the test partition. A better test in some ways, a worse test in others. * Tweak the license info to make "brew audit" happy
carlocab
reviewed
Dec 5, 2020
|
I was wondering where those |
carlocab
reviewed
Dec 5, 2020
Yeah, it's weird. See some of the discussion here https://news.ycombinator.com/item?id=23612772 I guess the dyld cache just comes prepopulated with all of the base libraries and the *.tbd files in places like /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/lib just tell the linker how to find it. However if you |
|
I suspect a similar patch might fix a whole lot of Big Sur build failures actually. Nice find. |
fxcoudert
approved these changes
Dec 6, 2020
|
🤖 A scheduled task has triggered a merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/usr/lib/*.dylibfor the standard libraries, but the toolchain can still link against them (using the.tbdfiles inside the SDK to guide it) Just use-lncurseswhich seems to work.Normally I would open an upstream PR first, but I'm having some issues with my long-unused Sourceforge account. (support ticket opened) I will ping the upstream dev though and will try to make sure this gets addressed in the next release. In the meantime I just put the tiny patch inline to the formula.
brew testwouldn't work for me. The first problem was thathdiutildoesn't seem capable of creating a 128k disk image any more, but the command works when I run it manually with a 512k size. However, it still doesn't work due to a permission issue when running insidebrew test-- I think something changed in how the test sandboxing works so that hdiutil can no longer run. (hdiutil can need expanded permissions since it temporarily mounts the new image I think) I couldn't find a clean way to work around it so I just changed the test to use this package itself to make the test partition. A better test in some ways, a worse test in others.Tweak the license info to make
brew audithappy