cvs: fix for Xcode 12 #65954
Closed
cvs: fix for Xcode 12 #65954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrewTestBot
added
the
missing license
|
No need for a revision |
|
My apologies... I thought that was required for any change that didn't bump the upstream version |
|
@mitchblank only when we want all users to be upgraded to the latest binaries. Here, existing users have a working version, so we don't need it |
fxcoudert
approved these changes
Nov 30, 2020
|
Thank you @mitchblank for your contribution to Home-brew! |
|
🤖 A scheduled task has triggered a merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that cvs was no longer building under the new Xcode. I don't regularly use cvs these days, but probably should be kept building.
The issue was similar to other formula like zsh (see cac377b) where the new xcode default flags of
-Werror,-Wimplicit-function-declarationcaused the ancient./configurescript to detect things wrong and then all hell breaks loose while compiling. Same fix as that formula works fine.I don't think the upstream package is closely maintained these days (cvs 1.12.13 is from 2005!), so just a local workaround is probably the best thing for this one.