Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

w3m 0.5.3-38 #65291

Closed
wants to merge 1 commit into from
Closed

w3m 0.5.3-38 #65291

wants to merge 1 commit into from

Conversation

fxcoudert
Copy link
Member

Debian has become upstream, really.

@BrewTestBot BrewTestBot added the missing license Formula has a missing license which should be added label Nov 20, 2020
@retokromer
Copy link
Contributor

To my knowledge, it’s a MIT license.

Formula/w3m.rb Outdated
Comment on lines 22 to 23
url :stable
regex(%r{url=.*?/w3m[._-]v?(\d+(?:\.\d+)+)\.t}i)
regex(%r{url=.*?/w3m[._-]v?(\d+(?:\.\d+)+)\.orig.t}i)
Copy link
Member

@nandahkrishna nandahkrishna Nov 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with the suggestions thing, but this should be:

  url "https://deb.debian.org/debian/pool/main/w/w3m/"
  regex(/href=.*?w3m[._-]v?(\d+(?:\.\d+)+)\.orig\.t/i)

This ensures 0.5.3 is still reported as the version found by livecheck.

@BrewTestBot
Copy link
Member

:shipit: @fxcoudert has triggered a merge.

@mitchblank
Copy link
Contributor

@fxcoudert -- you might want to try rebottling nmh as well. It had w3m as a dependency but build+test works fine for me locally.

@fxcoudert
Copy link
Member Author

If the linkage test and the tests worked fine, why would we rebottle nmh?

@fxcoudert fxcoudert deleted the w3m branch December 22, 2020 13:11
@mitchblank
Copy link
Contributor

If the linkage test and the tests worked fine, why would we rebottle nmh?

Just so we can get a big_sur native bottle for nmh so we can get it off of the #65000 list. It didn't happen duing the mass-rebottling, but that was possibly due to the w3m dependency, since it builds from source fine for me.

@fxcoudert
Copy link
Member Author

I can dispatch a Big Sur bottle build without revision bumping, just ping me when you see a formula that should build.

@mitchblank
Copy link
Contributor

Is there a particular place that is best to ping you at? My rebottling wishlist is getting long.

@fxcoudert
Copy link
Member Author

Any issue, here is fine :)

@mitchblank
Copy link
Contributor

Here are some entries from your #65000 list that either have had dependencies resolved OR I couldn't find out what had failed when I ran them manually. Some of them I've pinged people on other PRs as noted by the links:

2621 mingw-w64 -- compile/test worked fine for me manually; possibly just needs a rebottle now that more dependencies are done
1450 dpkg -- should be OK now that "po4a" dependency is fixed https://github.com/Homebrew/homebrew-core/pull/67336#issuecomment-749838688
176 bitcoin -- maybe will bottle now https://github.com/Homebrew/homebrew-core/pull/66852#issuecomment-744409428
147 bbftp-client -- built and tested fine for me manually
105 cabocha -- crf++ dependency fixed; probably just needs a re-bottle https://github.com/Homebrew/homebrew-core/pull/67265#issuecomment-748594850
97 libofx -- now may be ready for a rebottle; https://github.com/Homebrew/homebrew-core/pull/66986#issuecomment-748560325
72 dict -- maybe will rebottle now that libmaa depdency is fixed https://github.com/Homebrew/homebrew-core/pull/67266#issuecomment-748595185
58 launchdns -- compiled and tested fine for me, not sure what CI's problem was
26 lemon -- build/test manually worked for me
20 amap -- build/test worked ok for me manually
15 zpaq -- fix is merged, but needs a rebottling job kicked off
14 cvs-fast-export -- builds/installs fine.  probably failed to bottle because of "cvs" dependency which is already fixed
13 oq -- dependency sorted, maybe can be bottled? https://github.com/Homebrew/homebrew-core/pull/66796#issuecomment-748944514
8 get-flash-videos -- install+test worked fine for me, not sure what the bottling issue is
7 crystal-icr -- dependency sorted, maybe can be bottled? https://github.com/Homebrew/homebrew-core/pull/66796#issuecomment-748944514
5 zyre -- was broken due to czmq dependency, but may need more... or maybe test just doesn't like Little Snitch
1 reprepro -- maybe will bottle now https://github.com/Homebrew/homebrew-core/pull/66852#issuecomment-744409428

=== If mingw-64 succeeds above then do:

111 makensis -- depends_on "mingw-w64"

=== If libofx succeeds above then do:

113 homebank -- depends_on "libofx"

I don't know if all of them will bottle for Big Sur now but I bet some of them will.

@fxcoudert
Copy link
Member Author

@mitchblank I've queued bottles for all of those listed above, the failures should be linked here below

@BrewTestBot
Copy link
Member

@fxcoudert bottle request for launchdns failed.

@BrewTestBot
Copy link
Member

@fxcoudert bottle request for lemon failed.

@BrewTestBot
Copy link
Member

@fxcoudert bottle request for amap failed.

@BrewTestBot
Copy link
Member

@fxcoudert bottle request for get-flash-videos failed.

@BrewTestBot
Copy link
Member

@fxcoudert bottle request for oq failed.

@BrewTestBot
Copy link
Member

@fxcoudert bottle request for mingw-w64 failed.

@mitchblank
Copy link
Contributor

Well it looks like we got 12 successes and 6 failures.

bbftp-client.rb:    sha256 "74cbb945c2451974029b924f8ee6dc121b15c4dd301873560afd39d37f930686" => :big_sur
bitcoin.rb:    sha256 "cc325b9d083a2ecb7816ffc61cb4de7ac78e45cb56ecadce26132283595b83a8" => :big_sur
cabocha.rb:    sha256 "bd52ed1080db697c45768449954fcbc1ead6b41bd6a2481b843a1d7177155b34" => :big_sur
crystal-icr.rb:    sha256 "fcddd33608c0eccf38cd3f3e7bc299cfac6ca2b7020e7d3171eead79c932b2db" => :big_sur
cvs-fast-export.rb:    sha256 "af7e3b2fa6fd3c2e4095364bbf13af5e1aa9c00f7ff066f95f2b8485ce4b22b5" => :big_sur
dict.rb:    sha256 "e2f72aa23fa4294603f7c85da2c0748e97c36360e18845c929fc0de691ef8952" => :big_sur
dpkg.rb:    sha256 "4f28e3cf9f5efab34cfeca360751e5369552e9a5122e2b76b6375e0c7425999f" => :big_sur
libofx.rb:    sha256 "b7cfdbbdf131872ff2c0cb26c4e14ee2c346fa8e16c8e0293be58f4c60d43e2e" => :big_sur
makensis.rb:    sha256 "aa8a346937316765bf9ffe7d532b08212fab4ae697aad7e23185baeabe280249" => :big_sur
reprepro.rb:    sha256 "3064f238486aad600cf095168f03513679159bbbddbf50646d64be1bac1a8d36" => :big_sur
zpaq.rb:    sha256 "05c7f10eb18f64d77057a80ce7580bdf8dffd9d33e743259dae3984803dc9dd9" => :big_sur
zyre.rb:    sha256 "092d6682e5c0ca01066bdf991599e8104d382a80f5793ef1c9f57dcdfb5689eb" => :big_sur

@fxcoudert -- since libofx build OK could you do homebank now? It builds/tests fine for me locally now.

@mitchblank
Copy link
Contributor

@fxcoudert bottle request for launchdns failed.
This failed immediately due to:

==> brew audit launchdns --online --git --skip-style
==> FAILED
launchdns:
  * 'revision 1' should be removed
Error: 1 problem in 1 formula detected

Sure enough, when this was updated from 1.0.3 -> 1.0.4 the revision line was accidentally left on: 91c7119

However I don't know how to resolve the problem now. If I remove the revision 1 after we already have 1.0.4_1 bottles won't that look like a downgrade?

@mitchblank
Copy link
Contributor

mitchblank commented Dec 23, 2020

@fxcoudert bottle request for lemon failed.

Opened #67584 to fix download url (although the formula may have other long-term issues, as described)

@mitchblank
Copy link
Contributor

@fxcoudert bottle request for amap failed.

This failed to bottle because of a /usr/local/Cellar path ending up in a binary which I guess is a no-no somehow?

==> Bottling amap--5.4_3.big_sur.bottle.tar.gz...
/usr/bin/sudo --non-interactive /usr/sbin/purge
tar cf /Users/brew/actions-runner/_work/homebrew-core/homebrew-core/bottles/amap--5.4_3.big_sur.bottle.tar amap/5.4_3
/usr/bin/sudo --non-interactive /usr/sbin/purge
gzip -f amap-bottle.tar
/usr/bin/sudo --non-interactive /usr/sbin/purge
Warning: String '/usr/local/Cellar' still exists in these files:
/usr/local/Cellar/amap/5.4_3/bin/amap
 --> match '/usr/local/Cellar/amap/5.4_3' at offset 0x124de

Error: --keep-old was passed but there are changes in:
cellar: old: :any, new: "/usr/local/Cellar"

I don't fully understand what it is complaining about though.

@BrewTestBot
Copy link
Member

@dtrodrigues bottle request for neko failed.

@BrewTestBot
Copy link
Member

@dtrodrigues bottle request for odin failed.

@BrewTestBot
Copy link
Member

@dtrodrigues bottle request for pg_top failed.

@BrewTestBot
Copy link
Member

@dtrodrigues bottle request for po4a failed.

@mitchblank
Copy link
Contributor

@dtrodrigues bottle request for boost-python failed.

boost-python compiled OK on ARM, but brew test failed due to stricter dlopen() requirements I guess?

==> python
Traceback (most recent call last):

  File "<stdin>", line 2, in <module>
ImportError: dlopen(./hello.so, 2): no suitable image found.  Did find:
	file system relative paths not allowed in hardened programs
An exception occurred within a child process:

@BrewTestBot
Copy link
Member

@dtrodrigues bottle request for speech-tools failed.

@BrewTestBot
Copy link
Member

@dtrodrigues bottle request for spidermonkey failed.

@BrewTestBot
Copy link
Member

@dtrodrigues bottle request for rethinkdb failed.

@BrewTestBot
Copy link
Member

@dtrodrigues bottle request for tarantool failed.

@BrewTestBot
Copy link
Member

@dtrodrigues bottle request for zpaq failed.

@mitchblank
Copy link
Contributor

mitchblank commented Feb 22, 2021

@dtrodrigues bottle request for cvs failed.

Failed due to autoconf being too old I guess:

checking build system type... configure: error: /bin/sh build-aux/config.sub -apple-darwin20.3.0 failed

Normally this is easy to fix just by rerunning autotools. A bit more complicated in this case since we have existing patches that mess with configure which would have to be rethought :-/

EDIT: opened #71712 to try that

@BrewTestBot
Copy link
Member

@dtrodrigues bottle request for jack failed.

@mitchblank
Copy link
Contributor

@dtrodrigues bottle request for gnu-prolog failed.

configure: error: unsupported architecture arm-apple-darwin20.3.0

Not clear if it's just an autoconf-too-old issue there or if the package itself doesn't support ARM currently.

@BrewTestBot
Copy link
Member

@dtrodrigues bottle request for ponyc failed.

@mitchblank
Copy link
Contributor

@dtrodrigues bottle request for hdf5@1.8 failed.

Looks like we have a sha256 mismatch to track down there...

==> Verifying checksum for '238c78407b5ce3d60979d2814cf24d6a76a0c7423c600ce4ce692d25915ec8d9--hdf5-1.8.22.tar.bz2'
Error: SHA256 mismatch
Expected: 0ac77e1c22bce5bbbdb337bd7f97aeb5ef43c727a84ccb6d683d092eb57ebd8e
  Actual: 689b88c6a5577b05d603541ce900545779c96d62b6f83d3f23f46559b48893a4

@mitchblank
Copy link
Contributor

mitchblank commented Feb 22, 2021

@dtrodrigues bottle request for neko failed.

This looks like actually the bdw-gc dependency is built incorrectly in the ARM bottle!

ld: warning: ignoring file /opt/homebrew/lib/libgc.dylib, building for macOS-x86_64 but attempting to link with file built for macOS-arm64

EDIT: sorry, other way around. neko is forcing -arch x86_64 on the build command line, which is breaking when buidling against correctly ARM-built deps.

Looking near the top of https://github.com/HaxeFoundation/neko/blob/master/CMakeLists.txt :

set(CMAKE_OSX_ARCHITECTURES x86_64)

... so that's not really a great sign.

EDIT2: filed HaxeFoundation/neko#221 upstream

@mitchblank
Copy link
Contributor

@dtrodrigues bottle request for odin failed.

Looks like this one is fixed upstream: odin-lang/Odin@776c3f4#diff-1f0034637c3196a3296a2a9673068256f899131064f94daad4623dd1506d5b90

But not clear if it's fully done yet since there is still an open PR for arm support: odin-lang/Odin#738

@mitchblank
Copy link
Contributor

@dtrodrigues bottle request for pg_top failed.

Looks like we need to add a re-run of autoconf here:

checking build system type... configure: error: /bin/sh ./config.sub -apple-darwin20.3.0 failed

@mitchblank
Copy link
Contributor

@dtrodrigues bottle request for po4a failed.

Something failed to build in some perl module on ARM, unfortunately not clear what from the CI output:

==> /opt/homebrew/Cellar/po4a/0.62/bin/po4a-gettextize -f asciidoc -m en.tex -p out.pot
dyld: missing lazy symbol called

@mitchblank
Copy link
Contributor

@dtrodrigues bottle request for speech-tools failed.

Looks like upstream doesn't support arm64 yet?

==> make
Check system type
config/config:200: config/systems/arm64_Darwin.mak: No such file or directory
../config/config:200: ../config/systems/arm64_Darwin.mak: No such file or directory

That file doesn't exist in the upstream git yet, either.

@mitchblank
Copy link
Contributor

@dtrodrigues bottle request for spidermonkey failed.

Looks like some assumptions about compiler flags are baked into its configure script:

checking for valid optimization flags... no
configure: error: These compiler flags are invalid: -O3 -fomit-frame-pointer

Note that we build against a pretty old version of spidermonkey for dependency purposes so patching will probably be required to make this ARM buildable, if that is practical at all.

@mitchblank
Copy link
Contributor

@dtrodrigues bottle request for rethinkdb failed.

Looks like their patched version of v8 is too old to build on OS/X-plus-ARM:

./google/protobuf/stubs/atomicops_internals_macosx.h:162:50: error: unknown type name 'Atomic64'; did you mean 'Atomic32'?
inline Atomic64 Barrier_AtomicIncrement(volatile Atomic64* ptr,
                                                 ^~~~~~~~
                                                 Atomic32
./google/protobuf/stubs/atomicops.h:65:15: note: 'Atomic32' declared here
typedef int32 Atomic32;

Seems to be something under active development so hopefully there will be an upstream release addressing it sooner or later.

@mitchblank
Copy link
Contributor

@dtrodrigues bottle request for tarantool failed.

<inline asm>:30:2: error: unknown directive
        .type coro_startup, %function
        ^
1 error generated.
make[2]: *** [CMakeFiles/coro.dir/third_party/coro/coro.c.o] Error 1

Seems to possibly be a known issue with some bundled 3rd party code that is conditionally enabled? tarantool/tarantool#5684

@mitchblank
Copy link
Contributor

mitchblank commented Feb 22, 2021

@dtrodrigues bottle request for zpaq failed.

This one is weird, on ARM it built OK but the unit test failed with allocx: failed:

./zpaq extract archive.zpaq zpaq -to zpaq.new
zpaq v7.15 journaling archiver, compiled Feb 21 2021
archive.zpaq: Skipping block at 181396: allocx failed
1 versions, 0 files, 6 fragments, 0.181396 MB
Extracting 0.000000 MB in 0 files -threads 8
0.001 seconds (all OK)
cmp zpaq zpaq.new
cmp: zpaq.new: No such file or directory
make: *** [check] Error 2

One guess is possibly we need to compile with NOJIT on ARM? Looking at https://github.com/zpaq/zpaq/blob/master/libzpaq.h

  -DNOJIT   Don't assume x86-32 or x86-64 with SSE2 (slower).

EDIT: opened #71704

@mitchblank
Copy link
Contributor

@dtrodrigues bottle request for jack failed.

Looks like it's more CPU specific than I would have guessed:

../common/JackAtomic.h:31:15: error: use of undeclared identifier 'CAS'
    } while (!CAS(actual, actual + 1, val));
              ^

We are a version behind on that formula and @fxcoudert has already looked into it (but the PR went stale) #69123

@mitchblank
Copy link
Contributor

@dtrodrigues bottle request for ponyc failed.

/tmp/ponyc-20210221-3290-aquuat/build/libs/bin/llc: error: : error: unable to get target for 'arm-apple-darwin20.3.0', see --version and --triple.
make[3]: *** [except_try_catch.o] Error 1

Looks like just lack of upstream support.

@mitchblank mitchblank mentioned this pull request Feb 22, 2021
@mitchblank
Copy link
Contributor

mitchblank commented Feb 23, 2021

  • nauty failed to build because the website is down. I emailed the project maintainer who is now looking into it.

@fxcoudert -- could you try another 11-Intel rebottle on nauty? The previous failure was due to a power outage that took out the upstream's homepage/download That at least should be fixed now.

EDIT: thanks, it worked. Now we have both big_sur: and arm64_big_sur: bottles

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 26, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
missing license Formula has a missing license which should be added outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants