-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node 6.0.0 #633
node 6.0.0 #633
Conversation
sha256 "472ae46a205fb65cd784b22825b7354cddb4da5f46c1974272be43e55745ce6e" | ||
version "6.0.0-rc.3" | ||
end | ||
# devel do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remove this block entirely if there's no new development release.
@@ -47,7 +41,7 @@ class Node < Formula | |||
end | |||
|
|||
resource "icu4c" do | |||
url "https://ssl.icu-project.org/files/icu4c/56.1/icu4c-56_1-src.tgz" | |||
url "https://ssl.icu-project.org/files/icu4c/57.1/icu4c-57_1-src.tgz" | |||
mirror "https://ftp.mirrorservice.org/sites/download.qt-project.org/development_releases/prebuilt/icu/src/icu4c-56_1-src.tgz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mirror needs to be updated too.
@dunn |
All tests pass except |
Thanks for opening the Azure PR! Hopefully they'll merge it quickly. |
The ICU 57 upgrade didn't made it into node v6.0.0, so it should be reverted from this PR (as it's not supported). You also have to add a revision to the The |
How about introducing support for building against a shared c-ares? |
@jbergstroem: Is this comment nodejs/node#5775 (comment) still valid? If not adding an option to build against a shared c-ares shouldn't be a problem. |
@chrmoritz yes, I've landed shared support against c-ares. Additionally, if you want, building against a shared zlib and http-parser should work fine as well. |
Azure/azure-xplat-cli#2821 got merged into base branch. Are we waiting for a release? |
Also, check #638 for my motivation to keep npm packages out of homebrew. |
No need to wait. Can backport the patch with a link to the upstream commit and explanation it can be removed on next stable release, or simply use the commit diff as a |
@DomT4 Can we merge this now then? |
Awesome 🎉 |
brew install <formula>
(where<formula>
is the name of the formula you're submitting)?brew audit --strict --online <formula>
(after doingbrew install <formula>
)?Description
Update node to v6.0.0