Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unibilium 2.1.0 #61783

Closed
wants to merge 2 commits into from
Closed

unibilium 2.1.0 #61783

wants to merge 2 commits into from

Conversation

equal-l2
Copy link
Contributor

@equal-l2 equal-l2 commented Sep 30, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Several distros now consider https://github.com/neovim/unibilium as the upstream according to Repology, hence the change of upstream URL.

@BrewTestBot BrewTestBot added missing license Formula has a missing license which should be added and removed missing license Formula has a missing license which should be added labels Sep 30, 2020
chenrui333
chenrui333 previously approved these changes Sep 30, 2020
@chenrui333 chenrui333 dismissed their stale review September 30, 2020 19:59

upstream source change

@chenrui333
Copy link
Member

@equal-l2, thanks for the PR, just some nitpick requests:

  • can you file a gitub issue in the upstream/main repo of confirming the fork repo's wide adoption
  • also we need to update the homepage as well (as it still points to the main repo)

Thanks!

@chenrui333 chenrui333 added the almost there PR is nearly ready to merge label Sep 30, 2020
@SMillerDev SMillerDev added the upstream issue An upstream issue report is needed label Oct 2, 2020
@carlocab
Copy link
Member

It looks like @mauke has had no activity on GitHub since Feb 2018: https://github.com/mauke?tab=overview&from=2018-12-01&to=2018-12-31

@equal-l2
Copy link
Contributor Author

Yes, that's the reason why several distros have changed the upstream.

@carlocab
Copy link
Member

Yes, I understand. I was only bringing it up to point out that @mauke seems unlikely to respond to the issue you posted. I imagine you knew that, but I figured it would be useful to make clear to anyone else reading.

@equal-l2
Copy link
Contributor Author

You're right. Thanks for making it clear!

@BrewTestBot
Copy link
Member

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@BrewTestBot BrewTestBot added the stale No recent activity label Dec 11, 2020
@carlocab
Copy link
Member

Thoughts, @SMillerDev, @chenrui333?

Others that have switched upstream
Debian (Testing, Unstable)
FreeBSD
Gentoo
Manjaro
OpenBSD
Ubuntu (20.10)

Can't find anything that documents a reason for change though.

@BrewTestBot BrewTestBot removed the stale No recent activity label Dec 11, 2020
Copy link
Contributor

@SeekingMeaning SeekingMeaning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@equal-l2 equal-l2 deleted the patch-1 branch June 10, 2022 21:36
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
almost there PR is nearly ready to merge outdated PR was locked due to age upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants