Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpmtools 2.21 #61617

Closed
wants to merge 1 commit into from
Closed

cpmtools 2.21 #61617

wants to merge 1 commit into from

Conversation

alebcay
Copy link
Member

@alebcay alebcay commented Sep 24, 2020

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added the missing license Formula has a missing license which should be added label Sep 24, 2020
@SMillerDev
Copy link
Member

cpmcp: cannot open /private/tmp/cpmtools-test-20200924-94956-1srfl4l/disk.cpm (No such file or directory)

@BrewTestBot
Copy link
Member

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@BrewTestBot BrewTestBot added stale No recent activity and removed stale No recent activity labels Nov 26, 2020
mitchblank added a commit to mitchblank/homebrew-core that referenced this pull request Dec 8, 2020
This was just marked deprecated, but it actually builds/runs OK

There was a previous attempt a few months ago by @alebcay to upgrade
this pacakge to 2.21 but it failed due to "brew test" failing.  (Homebrew#61617)

However, I think the failure was not due to the upgrade but by
@fxcoudert's remval of its "libdsk" option (Homebrew#32207) which made what
had been an optional component required.  However, when built in this
mode you need to pass an extra "-T raw" to several utilities or they
don't always work.
BrewTestBot pushed a commit that referenced this pull request Dec 8, 2020
This was just marked deprecated, but it actually builds/runs OK

There was a previous attempt a few months ago by @alebcay to upgrade
this pacakge to 2.21 but it failed due to "brew test" failing.  (#61617)

However, I think the failure was not due to the upgrade but by
@fxcoudert's remval of its "libdsk" option (#32207) which made what
had been an optional component required.  However, when built in this
mode you need to pass an extra "-T raw" to several utilities or they
don't always work.

Closes #66507.

Signed-off-by: FX Coudert <fxcoudert@gmail.com>
Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
@mitchblank
Copy link
Contributor

I think this can be closed now since my cpmtools-fixing PR landed and it includes the upgrade to 2.21

@alebcay alebcay added the superseded PR was replaced by another PR label Dec 13, 2020
@alebcay
Copy link
Member Author

alebcay commented Dec 13, 2020

Superseded by #66507.

@alebcay alebcay closed this Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing license Formula has a missing license which should be added superseded PR was replaced by another PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants