Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php: use brewed gd & pcre2, reorganise dependencies #58832

Closed
wants to merge 1 commit into from

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Jul 30, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

  • Use brewed gd and pcre2 over bundled versions.
    • This should fix issues on Apple Silicon that we have already fixed in the pcre2 formula.
    • Using brewed gd means that freetype, jpeg, libpng and webp are no longer direct dependencies (but are dependencies of gd).
  • Make krb5 dependency explicit (was pulled by libpq and implicitly linked instead of the system version).
  • Clean-up unneeded libedit flags which have been solved by the addition of libedit.pc to Homebrew/brew.

@SeekingMeaning SeekingMeaning added 11 Big Sur is specifically affected maintainer feedback Additional maintainers' opinions may be needed labels Jul 30, 2020
@SeekingMeaning
Copy link
Contributor

DNM?

@SMillerDev
Copy link
Member

Please apply this to the versioned formula as well then.

@Bo98
Copy link
Member Author

Bo98 commented Jul 30, 2020

PHP 7.2 and 7.3 is less trivial and require backporting some patches. I'll have a look.

DNM?

While it would be nice to see if this fixes things on Apple Silicon, I ultimately would still be merging this PR anyway since we should prefer brewed libraries over bundled ones.

@SMillerDev
Copy link
Member

PHP 7.2 and 7.3 is less trivial and require backporting some patches. I'll have a look.

If it's not doable we can just skip it. Just wanted to make sure it was considered

Copy link
Member

@mistydemeo mistydemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this fixes PHP on Apple Silicon.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@Bo98 Bo98 deleted the php branch July 30, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Big Sur is specifically affected maintainer feedback Additional maintainers' opinions may be needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants