gcc: Fix version_suffix
#58558
Closed
gcc: Fix version_suffix
#58558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation was fundamentally broken when called from other formulae in HEAD builds. Per the discussion in https://discourse.brew.sh/t/calling-one-formulas-methods-in-another/8382, I've renamed the original method to `buildver_suffix` for internal use only, and defined a new `version_suffix` that does the right thing. The `version_suffix` comment is an implied acknowledgement that this method is for "public use".
gromgit
force-pushed
the
gcc_version_suffix
branch
from
59831bd to
519a08e
Compare
SeekingMeaning
added
the
maintainer feedback
MikeMcQuaid
requested changes
Jul 30, 2020
|
Agree with @MikeMcQuaid, do not see why we should have two methods doing pretty much the same thing in the GCC formula |
Yeah, I guess formalizing something like |
gromgit
added a commit
to gromgit/homebrew-core
that referenced
this pull request
Aug 1, 2020
Addresses Homebrew#58558 by replacing private `version_suffix` with public `linked_version`.
5 tasks
dawidd6
pushed a commit
that referenced
this pull request
Aug 2, 2020
Addresses #58558 by replacing private `version_suffix` with public `linked_version`.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation broke when called from other formulae in HEAD builds, as documented in https://discourse.brew.sh/t/calling-one-formulas-methods-in-another/8382. I've renamed the original method to
buildver_suffixfor internal use only, and defined a newversion_suffixthat does the right thing for external callers.Tested with normal and HEAD builds of my own formula (
gromgit/dev/umka).The
version_suffixcomment is meant to imply a "public API", while also documenting its interface for posterity a.k.a. "don't break this".brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?