Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm: remove obsolete workaround #58452

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Conversation

mistydemeo
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This workaround is no longer needed, and in fact the HEAD build now fails unless this is removed.

cc @Bo98

SMillerDev
SMillerDev previously approved these changes Jul 23, 2020
@Bo98
Copy link
Member

Bo98 commented Jul 23, 2020

Looks like it's because of llvm/llvm-project@61e8973.

In which case, I think we might want to add libcxxabi to the runtimes array (on HEAD only currently)?

(Tagging "do not merge" so automerge doesn't pull this before that question is answered)

@mistydemeo
Copy link
Contributor Author

Confirmed, adding that to the runtimes array is necessary for the build to complete. Amended, with a comment.

@Bo98 Bo98 removed the do not merge label Jul 24, 2020
@Bo98 Bo98 merged commit 1ae72bc into Homebrew:master Jul 24, 2020
@mistydemeo mistydemeo deleted the llvm_fix_head branch July 24, 2020 20:01
@carlocab carlocab mentioned this pull request Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants