Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Telnet for Apple Silicon #57303

Merged
merged 4 commits into from
Jul 2, 2020
Merged

Build Telnet for Apple Silicon #57303

merged 4 commits into from
Jul 2, 2020

Conversation

BytesGuy
Copy link
Contributor

@BytesGuy BytesGuy commented Jul 2, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Updated Formula for Telnet to build for Apple Silicon. I was unable to run brew audit due to errors installing gems (will try to resolve this soon).

adam@Adams-Mac homebrew-core % file /usr/local/bin/telnet
/usr/local/bin/telnet: Mach-O 64-bit executable arm64

This is my first PR to homebrew-core, so apologies if something is not quite right!

Formula/telnet.rb Outdated Show resolved Hide resolved
@Bo98
Copy link
Member

Bo98 commented Jul 2, 2020

I was unable to run brew audit due to errors installing gems (will try to resolve this soon).

Yeah there's a couple known issues there. One being a bug with system Ruby on Apple Silicon that has been reported to Apple.

@claui
Copy link
Contributor

claui commented Jul 2, 2020

errors installing gems (will try to resolve this soon)

Some analysis has been done in Homebrew/brew#7857 (look for FB7836181 there). It boils down to mkmf calling clang with -arch=arm64e while -arch=arm64 would have produced a working binary.

No idea how to coerce mkmf into using the proper architecture flavour.

@BytesGuy
Copy link
Contributor Author

BytesGuy commented Jul 2, 2020

@Bo98 @claui Thanks, will take a look into that!

BytesGuy and others added 2 commits July 2, 2020 16:41
Co-authored-by: Bo Anderson <mail@boanderson.me>
Formula/telnet.rb Outdated Show resolved Hide resolved
Co-authored-by: Bo Anderson <mail@boanderson.me>
@claui claui mentioned this pull request Jul 2, 2020
1 task
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bo98 Bo98 merged commit 7e1119b into Homebrew:master Jul 2, 2020
@claui claui added the 11 Big Sur is specifically affected label Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Big Sur is specifically affected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants