Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python@3.8: apply upstream patch temporarily for macOS ≥10.16 #56880

Merged
merged 1 commit into from
Jun 26, 2020
Merged

python@3.8: apply upstream patch temporarily for macOS ≥10.16 #56880

merged 1 commit into from
Jun 26, 2020

Conversation

claui
Copy link
Contributor

@claui claui commented Jun 25, 2020

As suggested, applying the upstream patch for now, as the next minor release isn’t to be expected until mid-July.

The patch is to be removed from the formula once 3.8.4 is released.

Closes #56791.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@claui
python@3.8: apply upstream patch for macOS 11.0
5c64980 
As suggested [1], applying the upstream patch for now, as the next
minor release isn’t to be expected until mid-July.

This patch is to be removed from the formula once 3.8.4 is released.

Closes #56791.

[1]: #56791

Suggested-by: CC: Bo Anderson <mail@boanderson.me>
@claui claui changed the title python@3.8: apply upstream patch temporarily for macOS 11.0 python@3.8: apply upstream patch temporarily for macOS ≥10.16 Jun 25, 2020
@claui
Copy link
Contributor Author

claui commented Jun 25, 2020

The 11.0 attribution was actually misleading: the root cause of the issue is the number 20 in Darwin 20.

So this PR actually fixes both macOS 10.16 and 11.0.

mistydemeo
mistydemeo approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@mistydemeo mistydemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for this!

@Bo98 Bo98 merged commit af0afd3 into Homebrew:master Jun 26, 2020
@claui claui deleted the python-3.8-patch branch July 1, 2020 10:11
@claui claui added the 11 Big Sur is specifically affected label Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistydemeo mistydemeo mistydemeo approved these changes

Assignees
No one assigned
Labels
11 Big Sur is specifically affected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.8 doesn't build on 11.0
3 participants
@claui @mistydemeo @Bo98