skaffold 1.5.0 #51233
Closed
skaffold 1.5.0 #51233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
reviewed
Mar 7, 2020
|
Looks like their build script is broken in Go 1.14: GoogleContainerTools/skaffold#3700 |
|
There's an open PR for switching to Go 1.14: GoogleContainerTools/skaffold#3775 |
|
@Bo98 does it make sense to change |
|
If a 1.14 patch is non-trivial and no release is imminent, sure that's fine. There should however be a comment in the formula file clearly indicating when it can be raised to 1.14 (next update or whatever). |
fix tag Co-Authored-By: Bo Anderson <mail@boanderson.me>
|
Yeah, I think we can ship and move back to go 1.14 after the next release. |
Bo98
approved these changes
Mar 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created with
brew bump-formula-pr.